]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
ASoC: amd: Return -ENODEV for non-existing ACPI call
authorTakashi Iwai <tiwai@suse.de>
Fri, 27 Nov 2020 14:31:59 +0000 (15:31 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 30 Nov 2020 12:52:46 +0000 (12:52 +0000)
AMD Renoir driver tries to identify the presence of DMIC by evaluating
ACPI _WOV entry, and it returns -EINVAL when the ACPI call failed.
This ended up an error message like
  snd_rn_pci_acp3x: probe of 0000:04:00.5 failed with error -22
although the system is correctly set up.

For avoiding such a superfluous error message, change the return value
to -ENODEV.  Then the driver core just skips to the next one without
complaining.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20201127143200.16272-3-tiwai@suse.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/renoir/rn-pci-acp3x.c

index b943e59fc302437580b14f45febe569819892d44..877350f38a68380d171af77c7faff609d5e52cb0 100644 (file)
@@ -224,7 +224,7 @@ static int snd_rn_acp_probe(struct pci_dev *pci,
                handle = ACPI_HANDLE(&pci->dev);
                ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
                if (ACPI_FAILURE(ret)) {
-                       ret = -EINVAL;
+                       ret = -ENODEV;
                        goto de_init;
                }
                if (!dmic_status) {