]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle_data
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Wed, 14 Feb 2018 17:30:29 +0000 (11:30 -0600)
committerCorey Minyard <cminyard@mvista.com>
Mon, 26 Feb 2018 15:21:28 +0000 (09:21 -0600)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1465255 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Cc: Haiyue Wang <haiyue.wang@linux.intel.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/kcs_bmc.c

index 3a3498afa427e14d699dbdd0ae24477a35f79cfe..6476bfb79f44692f147c8d18e0a0e6459b543874 100644 (file)
@@ -95,6 +95,7 @@ static void kcs_bmc_handle_data(struct kcs_bmc *kcs_bmc)
        switch (kcs_bmc->phase) {
        case KCS_PHASE_WRITE_START:
                kcs_bmc->phase = KCS_PHASE_WRITE_DATA;
+               /* fall through */
 
        case KCS_PHASE_WRITE_DATA:
                if (kcs_bmc->data_in_idx < KCS_MSG_BUFSIZ) {