]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
gpio: wm8994: don't print out global GPIO numbers in debugfs callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 26 Aug 2025 09:54:38 +0000 (11:54 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 3 Sep 2025 07:38:13 +0000 (09:38 +0200)
In order to further limit the number of references to the GPIO base
number stored in struct gpio_chip, replace the global GPIO numbers in
the output of debugfs callbacks by hardware offsets.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250826-gpio-dbg-show-base-v1-4-7f27cd7f2256@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-wm8994.c

index df47a27f508d94d53056bbe666a67e887637f516..a0665cf3ff2f45640cef740deca7712606791f47 100644 (file)
@@ -194,7 +194,6 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
        int i;
 
        for (i = 0; i < chip->ngpio; i++) {
-               int gpio = i + chip->base;
                int reg;
 
                /* We report the GPIO even if it's not requested since
@@ -208,14 +207,13 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
                        continue;
                }
 
-               seq_printf(s, " gpio-%-3d (%-20.20s) ", gpio,
+               seq_printf(s, " gpio-%-3d (%-20.20s) ", i,
                           label ?: "Unrequested");
 
                reg = wm8994_reg_read(wm8994, WM8994_GPIO_1 + i);
                if (reg < 0) {
                        dev_err(wm8994->dev,
-                               "GPIO control %d read failed: %d\n",
-                               gpio, reg);
+                               "GPIO control %d read failed: %d\n", i, reg);
                        seq_printf(s, "\n");
                        continue;
                }