]> www.infradead.org Git - users/willy/xarray.git/commitdiff
HSI: Fix PM usage counter unbalance in ssi_hw_init
authorZhang Qilong <zhangqilong3@huawei.com>
Mon, 23 Nov 2020 10:18:27 +0000 (18:18 +0800)
committerSebastian Reichel <sre@kernel.org>
Tue, 29 Dec 2020 22:57:06 +0000 (23:57 +0100)
pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.

Fixes: b209e047bc743 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/hsi/controllers/omap_ssi_core.c

index 7596dc16464843d86d1ee52c3cb2304d6220a590..44a3f5660c1090e3eb64c21a8acdbceb641fecb8 100644 (file)
@@ -424,7 +424,7 @@ static int ssi_hw_init(struct hsi_controller *ssi)
        struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi);
        int err;
 
-       err = pm_runtime_get_sync(ssi->device.parent);
+       err = pm_runtime_resume_and_get(ssi->device.parent);
        if (err < 0) {
                dev_err(&ssi->device, "runtime PM failed %d\n", err);
                return err;