habanalabs: add missing error check in sysfs clk_freq_mhz_show

Add a missing error check in the sysfs show functions for
clk_max_freq_mhz and clk_cur_freq_mhz_show.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

diff --git a/drivers/misc/habanalabs/common/sysfs.c b/drivers/misc/habanalabs/common/sysfs.c
index 3f220dd3b6b2165c9a283efb487b0ce85af21753..c665a3ac8876add09ead6e324a0f767d63b6221e 100644 (file)
--- a/drivers/misc/habanalabs/common/sysfs.c
+++ b/drivers/misc/habanalabs/common/sysfs.c
@@ -18,6 +18,8 @@ static ssize_t clk_max_freq_mhz_show(struct device *dev, struct device_attribute
                return -ENODEV;
 
        value = hl_fw_get_frequency(hdev, hdev->asic_prop.clk_pll_index, false);
+       if (value < 0)
+               return value;
 
        hdev->asic_prop.max_freq_value = value;
 
@@ -59,6 +61,8 @@ static ssize_t clk_cur_freq_mhz_show(struct device *dev, struct device_attribute
                return -ENODEV;
 
        value = hl_fw_get_frequency(hdev, hdev->asic_prop.clk_pll_index, true);
+       if (value < 0)
+               return value;
 
        return sprintf(buf, "%lu\n", (value / 1000 / 1000));
 }