]> www.infradead.org Git - users/willy/linux.git/commitdiff
staging: rtl8723bs: Cleanups for rtw_inc_and_chk_continual_io_error
authorChenguang Zhao <zhaochenguang@kylinos.cn>
Thu, 5 Dec 2024 02:16:10 +0000 (10:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Dec 2024 15:54:03 +0000 (16:54 +0100)
There's a warning when using checkpatch.pl check rtw_io.c:

    WARNING: Missing a blank line after declarations
    146: FILE: drivers/staging/rtl8723bs/core/rtw_io.c:146:
    int value = atomic_inc_return(&dvobj->continual_io_error);
    if (value > MAX_CONTINUAL_IO_ERR)

The patch fixes it.

In addition, also rename 'value' variable to 'error_count' and drop
'ret' variable.

Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241205021610.523528-1-zhaochenguang@kylinos.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_io.c

index fcda9db6ebb55a793a8eaa6abe7b9f2444c4d0bd..79d543d8827837e4ccce1b4660c3afb824be82f4 100644 (file)
@@ -141,12 +141,12 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt
 */
 int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj)
 {
-       int ret = false;
-       int value = atomic_inc_return(&dvobj->continual_io_error);
-       if (value > MAX_CONTINUAL_IO_ERR)
-               ret = true;
+       int error_count = atomic_inc_return(&dvobj->continual_io_error);
 
-       return ret;
+       if (error_count > MAX_CONTINUAL_IO_ERR)
+               return true;
+
+       return false;
 }
 
 /*