net: ti: icssg-prueth: Add multicast filtering support

Add multicast filtering support for ICSSG Driver. Multicast addresses will
be updated by __dev_mc_sync() API. icssg_prueth_add_macst () and
icssg_prueth_del_mcast() will be sync and unsync APIs for the driver
respectively.

To add a mac_address for a port, driver needs to call icssg_fdb_add_del()
and pass the mac_address and BIT(port_id) to the API. The ICSSG firmware
will then configure the rules and allow filtering.

If a mac_address is added to port0 and the same mac_address needs to be
added for port1, driver needs to pass BIT(port0) | BIT(port1) to the
icssg_fdb_add_del() API. If driver just pass BIT(port1) then the entry for
port0 will be overwritten / lost. This is a design constraint on the
firmware side.

To overcome this in the driver, to add any mac_address for let's say portX
driver first checks if the same mac_address is already added for any other
port. If yes driver calls icssg_fdb_add_del() with BIT(portX) |
BIT(other_existing_port). If not, driver calls icssg_fdb_add_del() with
BIT(portX).

The same thing is applicable for deleting mac_addresses as well. This
logic is in icssg_prueth_add_mcast / icssg_prueth_del_mcast APIs.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 6e65aa0977d400cad619a0cb5259c064685f6bcf..e13835100754f7ac5fef0e8ae62b66585da3dfa6 100644 (file)
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -439,6 +439,37 @@ const struct icss_iep_clockops prueth_iep_clockops = {
        .perout_enable = prueth_perout_enable,
 };
 
+static int icssg_prueth_add_mcast(struct net_device *ndev, const u8 *addr)
+{
+       struct prueth_emac *emac = netdev_priv(ndev);
+       int port_mask = BIT(emac->port_id);
+
+       port_mask |= icssg_fdb_lookup(emac, addr, 0);
+       icssg_fdb_add_del(emac, addr, 0, port_mask, true);
+       icssg_vtbl_modify(emac, 0, port_mask, port_mask, true);
+
+       return 0;
+}
+
+static int icssg_prueth_del_mcast(struct net_device *ndev, const u8 *addr)
+{
+       struct prueth_emac *emac = netdev_priv(ndev);
+       int port_mask = BIT(emac->port_id);
+       int other_port_mask;
+
+       other_port_mask = port_mask ^ icssg_fdb_lookup(emac, addr, 0);
+
+       icssg_fdb_add_del(emac, addr, 0, port_mask, false);
+       icssg_vtbl_modify(emac, 0, port_mask, port_mask, false);
+
+       if (other_port_mask) {
+               icssg_fdb_add_del(emac, addr, 0, other_port_mask, true);
+               icssg_vtbl_modify(emac, 0, other_port_mask, other_port_mask, true);
+       }
+
+       return 0;
+}
+
 /**
  * emac_ndo_open - EMAC device open
  * @ndev: network adapter device
@@ -599,6 +630,8 @@ static int emac_ndo_stop(struct net_device *ndev)
 
        icssg_class_disable(prueth->miig_rt, prueth_emac_slice(emac));
 
+       __dev_mc_unsync(ndev, icssg_prueth_del_mcast);
+
        atomic_set(&emac->tdown_cnt, emac->tx_ch_num);
        /* ensure new tdown_cnt value is visible */
        smp_mb__after_atomic();
@@ -675,10 +708,7 @@ static void emac_ndo_set_rx_mode_work(struct work_struct *work)
                return;
        }
 
-       if (!netdev_mc_empty(ndev)) {
-               emac_set_port_state(emac, ICSSG_EMAC_PORT_MC_FLOODING_ENABLE);
-               return;
-       }
+       __dev_mc_sync(ndev, icssg_prueth_add_mcast, icssg_prueth_del_mcast);
 }
 
 /**