]> www.infradead.org Git - users/hch/xfsprogs.git/commitdiff
xfs: namespace the maximum length/refcount symbols
authorDarrick J. Wong <djwong@kernel.org>
Thu, 15 Aug 2024 18:57:42 +0000 (11:57 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Wed, 9 Oct 2024 23:29:19 +0000 (16:29 -0700)
Actually namespace these variables properly, so that readers can tell
that this is an XFS symbol, and that it's for the refcount
functionality.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
libxfs/xfs_format.h
libxfs/xfs_refcount.c
repair/rmap.c
repair/scan.c

index cf2d42fbcb95c90f01b8a23cc33ee7279945050f..a3c72f88a78f2f7efd232f9c9d70c57148c6b1a2 100644 (file)
@@ -1807,8 +1807,8 @@ struct xfs_refcount_key {
        __be32          rc_startblock;  /* starting block number */
 };
 
-#define MAXREFCOUNT    ((xfs_nlink_t)~0U)
-#define MAXREFCEXTLEN  ((xfs_extlen_t)~0U)
+#define XFS_REFC_REFCOUNT_MAX  ((xfs_nlink_t)~0U)
+#define XFS_REFC_LEN_MAX       ((xfs_extlen_t)~0U)
 
 /* btree pointer type */
 typedef __be32 xfs_refcount_ptr_t;
index d173ac2757ea2d5ad4f6e79796d8ee10be3b9f24..91f33ab988c58c9cf27f378719f736d0b17c838e 100644 (file)
@@ -127,7 +127,7 @@ xfs_refcount_check_irec(
        struct xfs_perag                *pag,
        const struct xfs_refcount_irec  *irec)
 {
-       if (irec->rc_blockcount == 0 || irec->rc_blockcount > MAXREFCEXTLEN)
+       if (irec->rc_blockcount == 0 || irec->rc_blockcount > XFS_REFC_LEN_MAX)
                return __this_address;
 
        if (!xfs_refcount_check_domain(irec))
@@ -137,7 +137,7 @@ xfs_refcount_check_irec(
        if (!xfs_verify_agbext(pag, irec->rc_startblock, irec->rc_blockcount))
                return __this_address;
 
-       if (irec->rc_refcount == 0 || irec->rc_refcount > MAXREFCOUNT)
+       if (irec->rc_refcount == 0 || irec->rc_refcount > XFS_REFC_REFCOUNT_MAX)
                return __this_address;
 
        return NULL;
@@ -852,9 +852,9 @@ xfs_refc_merge_refcount(
        const struct xfs_refcount_irec  *irec,
        enum xfs_refc_adjust_op         adjust)
 {
-       /* Once a record hits MAXREFCOUNT, it is pinned there forever */
-       if (irec->rc_refcount == MAXREFCOUNT)
-               return MAXREFCOUNT;
+       /* Once a record hits XFS_REFC_REFCOUNT_MAX, it is pinned forever */
+       if (irec->rc_refcount == XFS_REFC_REFCOUNT_MAX)
+               return XFS_REFC_REFCOUNT_MAX;
        return irec->rc_refcount + adjust;
 }
 
@@ -897,7 +897,7 @@ xfs_refc_want_merge_center(
         * hence we need to catch u32 addition overflows here.
         */
        ulen += cleft->rc_blockcount + right->rc_blockcount;
-       if (ulen >= MAXREFCEXTLEN)
+       if (ulen >= XFS_REFC_LEN_MAX)
                return false;
 
        *ulenp = ulen;
@@ -932,7 +932,7 @@ xfs_refc_want_merge_left(
         * hence we need to catch u32 addition overflows here.
         */
        ulen += cleft->rc_blockcount;
-       if (ulen >= MAXREFCEXTLEN)
+       if (ulen >= XFS_REFC_LEN_MAX)
                return false;
 
        return true;
@@ -966,7 +966,7 @@ xfs_refc_want_merge_right(
         * hence we need to catch u32 addition overflows here.
         */
        ulen += cright->rc_blockcount;
-       if (ulen >= MAXREFCEXTLEN)
+       if (ulen >= XFS_REFC_LEN_MAX)
                return false;
 
        return true;
@@ -1195,7 +1195,7 @@ xfs_refcount_adjust_extents(
                 * Adjust the reference count and either update the tree
                 * (incr) or free the blocks (decr).
                 */
-               if (ext.rc_refcount == MAXREFCOUNT)
+               if (ext.rc_refcount == XFS_REFC_REFCOUNT_MAX)
                        goto skip;
                ext.rc_refcount += adj;
                trace_xfs_refcount_modify_extent(cur, &ext);
index 7a2b68f23e869b91f6e1404bb854b59347f88f1e..6b6c415694b7b6cf1f20a7ad8bebd9aa91fde70c 100644 (file)
@@ -894,7 +894,7 @@ refcount_emit(
                agno, agbno, len, nr_rmaps);
        rlrec.rc_startblock = agbno;
        rlrec.rc_blockcount = len;
-       nr_rmaps = min(nr_rmaps, MAXREFCOUNT);
+       nr_rmaps = min(nr_rmaps, XFS_REFC_REFCOUNT_MAX);
        rlrec.rc_refcount = nr_rmaps;
        rlrec.rc_domain = XFS_REFC_DOMAIN_SHARED;
 
index 83d0c6bca61912f57a9129193b220af656f1c91c..7a74f87c5f0c61fe74274ab1656eed59d7eeeff3 100644 (file)
@@ -1888,7 +1888,7 @@ _("extent (%u/%u) len %u claimed, state is %d\n"),
                                                break;
                                        }
                                }
-                       } else if (nr < 2 || nr > MAXREFCOUNT) {
+                       } else if (nr < 2 || nr > XFS_REFC_REFCOUNT_MAX) {
                                do_warn(
        _("invalid reference count %u in record %u of %s btree block %u/%u\n"),
                                        nr, i, name, agno, bno);