]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
i40e: use cpumask_copy instead of direct assignment
authorJacob Keller <jacob.e.keller@intel.com>
Wed, 12 Jul 2017 09:46:05 +0000 (05:46 -0400)
committerChuck Anderson <chuck.anderson@oracle.com>
Mon, 25 Sep 2017 19:54:33 +0000 (12:54 -0700)
According to the header file cpumask.h, we shouldn't be directly copying
a cpumask_t, since its a bitmap and might not be copied correctly. Lets
use the provided cpumask_copy() function instead.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Orabug: 26822609

(cherry picked from commit 7e4d01e7d3f7d4f7b0a768a1028cb26ea06c8694)
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Tested-by: Dib Chatterjee <dib.chatterjee@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
drivers/net/ethernet/intel/i40e/i40e_main.c
drivers/net/ethernet/intel/i40evf/i40evf_main.c

index dc0ef3571a36f69bce5330ea3999f5fcb6d758cb..6fcabd594dba79c31d6c3ee4714e2f871865ada3 100644 (file)
@@ -3471,7 +3471,7 @@ static void i40e_irq_affinity_notify(struct irq_affinity_notify *notify,
        struct i40e_q_vector *q_vector =
                container_of(notify, struct i40e_q_vector, affinity_notify);
 
-       q_vector->affinity_mask = *mask;
+       cpumask_copy(&q_vector->affinity_mask, mask);
 }
 
 /**
index 08ef1ce890482071dde9927dc2f3d43d7ea71817..882839992f135fd4c4ad5863ad004117fe21bb2f 100644 (file)
@@ -513,7 +513,7 @@ static void i40evf_irq_affinity_notify(struct irq_affinity_notify *notify,
        struct i40e_q_vector *q_vector =
                container_of(notify, struct i40e_q_vector, affinity_notify);
 
-       q_vector->affinity_mask = *mask;
+       cpumask_copy(&q_vector->affinity_mask, mask);
 }
 
 /**