]> www.infradead.org Git - users/hch/misc.git/commitdiff
i3c: master: svc: Flush FIFO before sending Dynamic Address Assignment(DAA)
authorFrank Li <Frank.Li@nxp.com>
Wed, 29 Jan 2025 16:22:50 +0000 (11:22 -0500)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 20 Feb 2025 22:20:28 +0000 (23:20 +0100)
Ensure the FIFO is empty before issuing the DAA command to prevent
incorrect command data from being sent. Align with other data transfers,
such as svc_i3c_master_start_xfer_locked(), which flushes the FIFO before
sending a command.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20250129162250.3629189-1-Frank.Li@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/svc-i3c-master.c

index 413479b12ba696a6dccdd4238e17398d8d4c856a..98f800f999691438dfcf7f156d3815bca8a383a6 100644 (file)
@@ -892,6 +892,8 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master,
        u32 reg;
        int ret, i;
 
+       svc_i3c_master_flush_fifo(master);
+
        while (true) {
                /* clean SVC_I3C_MINT_IBIWON w1c bits */
                writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS);