]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
pinctrl: apple: give error label a specific name
authorJoey Gouly <joey.gouly@arm.com>
Sun, 21 Nov 2021 16:56:38 +0000 (16:56 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 26 Nov 2021 23:55:14 +0000 (00:55 +0100)
Signed-off-by: Joey Gouly <joey.gouly@arm.com>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20211121165642.27883-8-joey.gouly@arm.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-apple-gpio.c

index fba2d4ec383cc9743bc79a2f1466ecdeddc36f03..fb34cbe189ce893d854062e3ea6db18aabcd05ae 100644 (file)
@@ -392,13 +392,13 @@ static int apple_gpio_register(struct apple_gpio_pinctrl *pctl)
                                         GFP_KERNEL);
                if (!girq->parents || !irq_data) {
                        ret = -ENOMEM;
-                       goto out;
+                       goto out_free_irq_data;
                }
 
                for (i = 0; i < girq->num_parents; i++) {
                        ret = platform_get_irq(to_platform_device(pctl->dev), i);
                        if (ret < 0)
-                               goto out;
+                               goto out_free_irq_data;
 
                        girq->parents[i] = ret;
                        pctl->irqgrps[i] = i;
@@ -412,7 +412,8 @@ static int apple_gpio_register(struct apple_gpio_pinctrl *pctl)
        }
 
        ret = devm_gpiochip_add_data(pctl->dev, &pctl->gpio_chip, pctl);
-out:
+
+out_free_irq_data:
        kfree(girq->parents);
        kfree(irq_data);