]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
serdev: Refine several error or debug messages
authorZijun Hu <quic_zijuhu@quicinc.com>
Fri, 25 Apr 2025 12:48:10 +0000 (20:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 May 2025 15:20:49 +0000 (17:20 +0200)
Refine several dev_err() and dev_dbg() messages to solve:

// hardcoded device name
dev_dbg(dev, "...dev_name_str...")

// repeated device name since dev_dbg() also prints it as prefix
dev_err(dev, "...%s...", dev_name(dev))

// not concise as dev_err(dev, "...%d...", err)
dev_err(dev, "...%pe...", ERR_PTR(err))

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20250425-fix_serdev-v3-1-2e4ea8261640@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serdev/core.c

index eb2a2e58fe78fbbdb5839232936a994bda86d0b4..0213381fa35876f43f2f10f6c444160cde73a686 100644 (file)
@@ -118,12 +118,11 @@ int serdev_device_add(struct serdev_device *serdev)
 
        err = device_add(&serdev->dev);
        if (err < 0) {
-               dev_err(&serdev->dev, "Can't add %s, status %pe\n",
-                       dev_name(&serdev->dev), ERR_PTR(err));
+               dev_err(&serdev->dev, "Failed to add serdev: %d\n", err);
                goto err_clear_serdev;
        }
 
-       dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
+       dev_dbg(&serdev->dev, "serdev registered successfully\n");
 
        return 0;
 
@@ -783,8 +782,7 @@ int serdev_controller_add(struct serdev_controller *ctrl)
                goto err_rpm_disable;
        }
 
-       dev_dbg(&ctrl->dev, "serdev%d registered: dev:%p\n",
-               ctrl->nr, &ctrl->dev);
+       dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n", &ctrl->dev);
        return 0;
 
 err_rpm_disable: