]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/mxsfb: put the bridge returned by drm_bridge_chain_get_first_bridge()
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 8 Jul 2025 15:48:20 +0000 (17:48 +0200)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 22 Jul 2025 11:01:28 +0000 (13:01 +0200)
The bridge returned by drm_bridge_chain_get_first_bridge() is
refcounted. Put it when done. Use a scope-based free action to catch all
the code paths.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20250708-drm-bridge-alloc-getput-drm_bridge_chain_get_first_bridge-v9-3-db1ba3df7f58@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/mxsfb/lcdif_kms.c

index dbd42cc1da87f82ef9cd4ccc70cdecbe56035174..1c3b33be6c40f5e6e25b0104040bf4eb56e06081 100644 (file)
@@ -433,7 +433,6 @@ static int lcdif_crtc_atomic_check(struct drm_crtc *crtc,
        struct drm_connector *connector;
        struct drm_encoder *encoder;
        struct drm_bridge_state *bridge_state;
-       struct drm_bridge *bridge;
        u32 bus_format, bus_flags;
        bool format_set = false, flags_set = false;
        int ret, i;
@@ -453,7 +452,8 @@ static int lcdif_crtc_atomic_check(struct drm_crtc *crtc,
 
                encoder = connector_state->best_encoder;
 
-               bridge = drm_bridge_chain_get_first_bridge(encoder);
+               struct drm_bridge *bridge __free(drm_bridge_put) =
+                       drm_bridge_chain_get_first_bridge(encoder);
                if (!bridge)
                        continue;