]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
block/throttle: Remove protocol-related fields
authorFabiano Rosas <farosas@linux.vnet.ibm.com>
Mon, 12 Mar 2018 22:07:51 +0000 (19:07 -0300)
committerKevin Wolf <kwolf@redhat.com>
Mon, 26 Mar 2018 10:16:00 +0000 (12:16 +0200)
The throttle driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.

Attempts to invoke this driver using protocol syntax
(i.e. throttle:<filename:options:...>) will now fail gracefully:

  $ qemu-img info throttle:foo
  qemu-img: Could not open 'throttle:foo': Unknown protocol 'throttle'

Signed-off-by: Fabiano Rosas <farosas@linux.vnet.ibm.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/throttle.c

index 5f4d43d0fc57b84515bfb3790c28e9e9ec4ec603..95ed06acd8ddc61281d3d07c9eebfae568689b34 100644 (file)
@@ -215,10 +215,9 @@ static void coroutine_fn throttle_co_drain_end(BlockDriverState *bs)
 
 static BlockDriver bdrv_throttle = {
     .format_name                        =   "throttle",
-    .protocol_name                      =   "throttle",
     .instance_size                      =   sizeof(ThrottleGroupMember),
 
-    .bdrv_file_open                     =   throttle_open,
+    .bdrv_open                          =   throttle_open,
     .bdrv_close                         =   throttle_close,
     .bdrv_co_flush                      =   throttle_co_flush,