]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/ssd130x: Remove the use of dev_err_probe()
authorLiao Yuanhong <liaoyuanhong@vivo.com>
Wed, 20 Aug 2025 13:14:15 +0000 (21:14 +0800)
committerJavier Martinez Canillas <javierm@redhat.com>
Mon, 1 Sep 2025 14:09:19 +0000 (16:09 +0200)
Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20250820131416.500048-1-liaoyuanhong@vivo.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
drivers/gpu/drm/solomon/ssd130x-spi.c

index 7c935870f7d2a9ace7a4d6b7fdb71b4bd154c3f0..b52f5fd592a19d6f7fa091b1b49fc3466cff1703 100644 (file)
@@ -74,8 +74,7 @@ static int ssd130x_spi_probe(struct spi_device *spi)
 
        t = devm_kzalloc(dev, sizeof(*t), GFP_KERNEL);
        if (!t)
-               return dev_err_probe(dev, -ENOMEM,
-                                    "Failed to allocate SPI transport data\n");
+               return -ENOMEM;
 
        t->spi = spi;
        t->dc = dc;