drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

[ Upstream commit 761e9f4f80a21a4b845097027030bef863001636 ]

The of_drm_find_bridge() function returns NULL on error, it doesn't return
error pointers so this check doesn't work.

Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200430073145.52321-1-weiyongjun1@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
index 7af5ebb0c43689776f13b37a2f41a5f6a972dc35..e705afc08c4e3feb54ed9551c69c7574e5422130 100644 (file)
--- a/drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/drivers/gpu/drm/mcde/mcde_dsi.c
@@ -1073,10 +1073,9 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,
                        panel = NULL;
 
                        bridge = of_drm_find_bridge(child);
-                       if (IS_ERR(bridge)) {
-                               dev_err(dev, "failed to find bridge (%ld)\n",
-                                       PTR_ERR(bridge));
-                               return PTR_ERR(bridge);
+                       if (!bridge) {
+                               dev_err(dev, "failed to find bridge\n");
+                               return -EINVAL;
                        }
                }
        }