crypto: axis/artpec6 - Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
index 8493a45e1bd46f0b18c62fb03e6f0451104145ea..07996b6c34464a47160ee2848295d0587f709703 100644 (file)
--- a/drivers/crypto/axis/artpec6_crypto.c
+++ b/drivers/crypto/axis/artpec6_crypto.c
@@ -2957,7 +2957,7 @@ free_cache:
        return err;
 }
 
-static int artpec6_crypto_remove(struct platform_device *pdev)
+static void artpec6_crypto_remove(struct platform_device *pdev)
 {
        struct artpec6_crypto *ac = platform_get_drvdata(pdev);
        int irq = platform_get_irq(pdev, 0);
@@ -2977,12 +2977,11 @@ static int artpec6_crypto_remove(struct platform_device *pdev)
 #ifdef CONFIG_DEBUG_FS
        artpec6_crypto_free_debugfs();
 #endif
-       return 0;
 }
 
 static struct platform_driver artpec6_crypto_driver = {
        .probe   = artpec6_crypto_probe,
-       .remove  = artpec6_crypto_remove,
+       .remove_new = artpec6_crypto_remove,
        .driver  = {
                .name  = "artpec6-crypto",
                .of_match_table = artpec6_crypto_of_match,