ionic: remove the unused nb_work

Remove the empty and unused nb_work and associated
ionic_lif_notify_work() function.

v2: separated from previous net patch

Link: https://lore.kernel.org/netdev/20241210174828.69525-2-shannon.nelson@amd.com/
Signed-off-by: Brett Creeley <brett.creeley@amd.com>
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Link: https://patch.msgid.link/20241212212042.9348-1-shannon.nelson@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h b/drivers/net/ethernet/pensando/ionic/ionic.h
index 0639bf56bd3afaf134f1142cfb87d46ad29273f9..04f00ea94230a2a188de398abbfa6fc8304c9f98 100644 (file)
--- a/drivers/net/ethernet/pensando/ionic/ionic.h
+++ b/drivers/net/ethernet/pensando/ionic/ionic.h
@@ -57,7 +57,6 @@ struct ionic {
        DECLARE_BITMAP(intrs, IONIC_INTR_CTRL_REGS_MAX);
        cpumask_var_t *affinity_masks;
        struct delayed_work doorbell_check_dwork;
-       struct work_struct nb_work;
        struct notifier_block nb;
        struct rw_semaphore vf_op_lock; /* lock for VF operations */
        struct ionic_vf *vfs;

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index 052c767a2c757872e0e1da86fe37ccdc11eaabea..05fb46effe0df1854c9dc66c92bc45a3c7023c59 100644 (file)
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -3804,10 +3804,6 @@ err_out_adminq_deinit:
        return err;
 }
 
-static void ionic_lif_notify_work(struct work_struct *ws)
-{
-}
-
 static void ionic_lif_set_netdev_info(struct ionic_lif *lif)
 {
        struct ionic_admin_ctx ctx = {
@@ -3858,8 +3854,6 @@ int ionic_lif_register(struct ionic_lif *lif)
 
        ionic_lif_register_phc(lif);
 
-       INIT_WORK(&lif->ionic->nb_work, ionic_lif_notify_work);
-
        lif->ionic->nb.notifier_call = ionic_lif_notify;
 
        err = register_netdevice_notifier(&lif->ionic->nb);
@@ -3885,7 +3879,6 @@ void ionic_lif_unregister(struct ionic_lif *lif)
 {
        if (lif->ionic->nb.notifier_call) {
                unregister_netdevice_notifier(&lif->ionic->nb);
-               cancel_work_sync(&lif->ionic->nb_work);
                lif->ionic->nb.notifier_call = NULL;
        }