]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
fabrics: autoconnect: explicitly express module dependency
authorDaniel Wagner <dwagner@suse.de>
Thu, 12 Oct 2023 07:29:30 +0000 (09:29 +0200)
committerDaniel Wagner <wagi@monom.org>
Wed, 8 Nov 2023 12:53:35 +0000 (13:53 +0100)
Use Wants/After to let systemd handle loading the kernel module, which
is the preferred way.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
nvmf-autoconnect/systemd/nvmf-autoconnect.service.in

index 621879a5f04b99d15caea83a8a40c7ba6b6f5223..92960cde6144fcc98d23ee8a491a86abc179480d 100644 (file)
@@ -2,12 +2,13 @@
 Description=Connect NVMe-oF subsystems automatically during boot
 ConditionPathExists=|@SYSCONFDIR@/nvme/config.json
 ConditionPathExists=|@SYSCONFDIR@/nvme/discovery.conf
+Wants=modprobe@nvme_fabrics.service
+After=modprobe@nvme_fabrics.service
 After=network-online.target
 Before=remote-fs-pre.target
 
 [Service]
 Type=oneshot
-ExecStartPre=/sbin/modprobe nvme-fabrics
 ExecStart=@SBINDIR@/nvme connect-all --context=autoconnect
 
 [Install]