ALSA: scarlett2: Add missing check with firmware version control

scarlett2_add_firmware_version_ctl() may return an error, but the
return value was not being checked. Add the missing check.

Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
Fixes: 701949cc0128 ("ALSA: scarlett2: Add support for reading firmware version")
Link: https://lore.kernel.org/r/ZTuKcXajVnuelBEb@m.b4.vu
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c
index 462a66d485c872bd1483a24bb8254530eb012e9c..f7c57a2c3028f1ecca5c5c5eb054ca5121d3ec49 100644 (file)
--- a/sound/usb/mixer_scarlett2.c
+++ b/sound/usb/mixer_scarlett2.c
@@ -4424,6 +4424,8 @@ static int snd_scarlett2_controls_create(
 
        /* Add firmware version control */
        err = scarlett2_add_firmware_version_ctl(mixer);
+       if (err < 0)
+               return err;
 
        /* Read volume levels and controls from the interface */
        err = scarlett2_read_configs(mixer);