]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: mctp: Fix bad kfree_skb in bind lookup test
authorMatt Johnston <matt@codeconstruct.com.au>
Tue, 12 Aug 2025 05:08:58 +0000 (13:08 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 14 Aug 2025 00:07:34 +0000 (17:07 -0700)
The kunit test's skb_pkt is consumed by mctp_dst_input() so shouldn't be
freed separately.

Fixes: e6d8e7dbc5a3 ("net: mctp: Add bind lookup test")
Reported-by: Alexandre Ghiti <alex@ghiti.fr>
Closes: https://lore.kernel.org/all/734b02a3-1941-49df-a0da-ec14310d41e4@ghiti.fr/
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Tested-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Link: https://patch.msgid.link/20250812-fix-mctp-bind-test-v1-1-5e2128664eb3@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mctp/test/route-test.c

index fb6b46a952cb432163f6adb40bb395d658745efd..69a3ccfc6310cd78d4138f56609f1d83d4082bd1 100644 (file)
@@ -1586,7 +1586,6 @@ static void mctp_test_bind_lookup(struct kunit *test)
 
 cleanup:
        kfree_skb(skb_sock);
-       kfree_skb(skb_pkt);
 
        /* Drop all binds */
        for (size_t i = 0; i < ARRAY_SIZE(lookup_binds); i++)