]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
i2c: stm32f7: use dev_err_probe upon calls of devm_request_irq
authorAlain Volmat <alain.volmat@foss.st.com>
Fri, 15 Dec 2023 17:06:05 +0000 (18:06 +0100)
committerWolfram Sang <wsa@kernel.org>
Thu, 18 Jan 2024 20:10:44 +0000 (21:10 +0100)
Convert error handling upon calls of devm_request_irq functions during
the probe of the driver.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-stm32f7.c

index 983509936727edfdd8f28320076f2f2ef068263b..d99f152ac72752eccff53f610de53b23e62935dc 100644 (file)
@@ -2199,19 +2199,13 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
                                        stm32f7_i2c_isr_event_thread,
                                        IRQF_ONESHOT,
                                        pdev->name, i2c_dev);
-       if (ret) {
-               dev_err(&pdev->dev, "Failed to request irq event %i\n",
-                       irq_event);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(&pdev->dev, ret, "Failed to request irq event\n");
 
        ret = devm_request_irq(&pdev->dev, irq_error, stm32f7_i2c_isr_error, 0,
                               pdev->name, i2c_dev);
-       if (ret) {
-               dev_err(&pdev->dev, "Failed to request irq error %i\n",
-                       irq_error);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(&pdev->dev, ret, "Failed to request irq error\n");
 
        setup = of_device_get_match_data(&pdev->dev);
        if (!setup) {