]> www.infradead.org Git - users/mchehab/rasdaemon.git/commitdiff
rasdaemon: add internal errors of IA32_MC4_STATUS for Haswell
authorSeiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
Wed, 17 Jun 2015 10:56:57 +0000 (07:56 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 3 Jul 2015 10:31:02 +0000 (07:31 -0300)
Now rasdaemon looks purposely omitting internal errors of
IA32_MC4_STATUS for Haswell-family processors, which are described in
Intel SDM vol3 Table 16-20. I think it's better to show these errors
because mcelog does show them.

Signed-off-by: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
mce-intel-haswell.c

index 0a817bf6047bba4cfb2dbc14aec475e62a0200ae..b70e3995e3c1402be0ecabfec93056e139202443 100644 (file)
@@ -126,18 +126,17 @@ void hsw_decode_model(struct ras_events *ras, struct mce_event *e)
         case 4:
                 switch (EXTRACT(status, 0, 15) & ~(1ull << 12)) {
                 case 0x402: case 0x403:
-                        /* Internal errors */
+                        mce_snprintf(e->mcastatus_msg, "PCU Internal Errors");
                         break;
                 case 0x406:
-                        /* Intel TXT errors */
+                        mce_snprintf(e->mcastatus_msg, "Intel TXT Errors");
                         break;
                 case 0x407:
-                        /* Other UBOX Internal errors */
+                        mce_snprintf(e->mcastatus_msg, "Other UBOX Internal Errors");
                         break;
                 }
-                if (EXTRACT(status, 16, 19))
-                        /* PCU internal error */
-                        ;
+                if (EXTRACT(status, 16, 17) && !EXTRACT(status, 18, 19))
+                        mce_snprintf(e->error_msg, "PCU Internal error");
                 decode_bitfield(e, status, pcu_mc4);
                 break;
         case 5: