]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ice: Remove likely for napi_complete_done
authorMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Tue, 25 Jan 2022 16:04:39 +0000 (17:04 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 27 Jan 2022 16:25:32 +0000 (17:25 +0100)
Remove the likely before napi_complete_done as this is the unlikely case
when busy-poll is used. Removing this has a positive performance impact
for busy-poll and no negative impact to the regular case.

Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
Link: https://lore.kernel.org/bpf/20220125160446.78976-2-maciej.fijalkowski@intel.com
drivers/net/ethernet/intel/ice/ice_txrx.c

index 3e38695f1c9d811182c2b23e4eaebe4b3b05fe7f..e661d0e45b9b70647d4418295b0cf2b13ab3d9c8 100644 (file)
@@ -1513,7 +1513,7 @@ int ice_napi_poll(struct napi_struct *napi, int budget)
        /* Exit the polling mode, but don't re-enable interrupts if stack might
         * poll us due to busy-polling
         */
-       if (likely(napi_complete_done(napi, work_done))) {
+       if (napi_complete_done(napi, work_done)) {
                ice_net_dim(q_vector);
                ice_enable_interrupt(q_vector);
        } else {