]> www.infradead.org Git - users/hch/dma-mapping.git/commitdiff
ASoC: rt715: modification for code simplicity
authorJack Yu <jack.yu@realtek.com>
Mon, 29 Mar 2021 06:54:05 +0000 (06:54 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 16 Apr 2021 16:19:59 +0000 (17:19 +0100)
Modification for code simplicity.

Signed-off-by: Jack Yu <jack.yu@realtek.com>
Link: https://lore.kernel.org/r/340ee2df83ce47fcb1b59541b12ba7f4@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt715.c

index f419d001a3fb930a106056f004e2dcbb793595ca..0f78ffbb03fd6bd32c3b63ee035652a9f24aa893 100644 (file)
@@ -57,14 +57,14 @@ static void rt715_get_gain(struct rt715_priv *rt715, unsigned int addr_h,
 {
        int ret;
        /* R Channel */
-       *r_val = (val_h << 8);
+       *r_val = val_h << 8;
        ret = regmap_read(rt715->regmap, addr_l, r_val);
        if (ret < 0)
                pr_err("Failed to get R channel gain.\n");
 
        /* L Channel */
        val_h |= 0x20;
-       *l_val = (val_h << 8);
+       *l_val = val_h << 8;
        ret = regmap_read(rt715->regmap, addr_h, l_val);
        if (ret < 0)
                pr_err("Failed to get L channel gain.\n");
@@ -188,8 +188,8 @@ static int rt715_set_amp_gain_get(struct snd_kcontrol *kcontrol,
 
        if (mc->invert) {
                /* for mute status */
-               read_ll = !((read_ll & 0x80) >> RT715_MUTE_SFT);
-               read_rl = !((read_rl & 0x80) >> RT715_MUTE_SFT);
+               read_ll = !(read_ll & 0x80);
+               read_rl = !(read_rl & 0x80);
        } else {
                /* for gain */
                read_ll = read_ll & 0x7f;