netfilter: add audit table unregister actions

Audit the action of unregistering ebtables and x_tables.

See: https://github.com/linux-audit/audit-kernel/issues/44

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>

diff --git a/include/linux/audit.h b/include/linux/audit.h
index 5c7f07a9776d255f209916b95a67fa6b765ae037..1a23515082113e2b261bd7772fb209e6370fc432 100644 (file)
--- a/include/linux/audit.h
+++ b/include/linux/audit.h
@@ -97,6 +97,7 @@ struct audit_ntp_data {};
 enum audit_nfcfgop {
        AUDIT_XT_OP_REGISTER,
        AUDIT_XT_OP_REPLACE,
+       AUDIT_XT_OP_UNREGISTER,
 };
 
 extern int is_audit_feature_set(int which);

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 705beac0ce29b9fc1a9601339d660f0b9dee24be..d281c18d1771a6708a89ec3787d79149832f1137 100644 (file)
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -136,8 +136,9 @@ struct audit_nfcfgop_tab {
 };
 
 const struct audit_nfcfgop_tab audit_nfcfgs[] = {
-       { AUDIT_XT_OP_REGISTER, "register"      },
-       { AUDIT_XT_OP_REPLACE,  "replace"       },
+       { AUDIT_XT_OP_REGISTER,         "register"      },
+       { AUDIT_XT_OP_REPLACE,          "replace"       },
+       { AUDIT_XT_OP_UNREGISTER,       "unregister"    },
 };
 
 static int audit_match_perm(struct audit_context *ctx, int mask)

diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 0a148e68b6e150e87bd4bcbcb3941fcacf5dceb9..4778db5601b0d082a2d932e0cd6548964cf69a81 100644 (file)
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -1124,6 +1124,8 @@ static void __ebt_unregister_table(struct net *net, struct ebt_table *table)
        mutex_lock(&ebt_mutex);
        list_del(&table->list);
        mutex_unlock(&ebt_mutex);
+       audit_log_nfcfg(table->name, AF_BRIDGE, table->private->nentries,
+                       AUDIT_XT_OP_UNREGISTER);
        EBT_ENTRY_ITERATE(table->private->entries, table->private->entries_size,
                          ebt_cleanup_entry, net, NULL);
        if (table->private->nentries)

diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
index 8f8c5dbf603df2c5f73e8bb0e894031191fbd7ea..99a468be4a59fb1995c91d8400b0cc2bf987623a 100644 (file)
--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -1472,6 +1472,8 @@ void *xt_unregister_table(struct xt_table *table)
        private = table->private;
        list_del(&table->list);
        mutex_unlock(&xt[table->af].mutex);
+       audit_log_nfcfg(table->name, table->af, private->number,
+                       AUDIT_XT_OP_UNREGISTER);
        kfree(table);
 
        return private;