projects
/
users
/
hch
/
misc.git
/ commitdiff
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
88d47f6
)
rust: block: simplify Result<()> in validate_block_size return
author
Manas <manas18244@iiitd.ac.in>
Mon, 18 Nov 2024 14:36:58 +0000
(20:06 +0530)
committer
Jens Axboe <axboe@kernel.dk>
Mon, 18 Nov 2024 16:10:33 +0000
(09:10 -0700)
`Result` is used in place of `Result<()>` because the default type
parameters are unit `()` and `Error` types, which are automatically
inferred. Thus keep the usage consistent throughout codebase.
Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link:
https://github.com/Rust-for-Linux/linux/issues/1128
Signed-off-by: Manas <manas18244@iiitd.ac.in>
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Link:
https://lore.kernel.org/r/20241118-simplify-result-v3-1-6b1566a77eab@iiitd.ac.in
Signed-off-by: Jens Axboe <axboe@kernel.dk>
rust/kernel/block/mq/gen_disk.rs
patch
|
blob
|
history
diff --git
a/rust/kernel/block/mq/gen_disk.rs
b/rust/kernel/block/mq/gen_disk.rs
index 708125dce96a934f32caab44d5e6cff14c4321a9..798c4ae0bdedd58221b5851a630c0e1052e0face 100644
(file)
--- a/
rust/kernel/block/mq/gen_disk.rs
+++ b/
rust/kernel/block/mq/gen_disk.rs
@@
-45,7
+45,7
@@
impl GenDiskBuilder {
/// Validate block size by verifying that it is between 512 and `PAGE_SIZE`,
/// and that it is a power of two.
- fn validate_block_size(size: u32) -> Result
<()>
{
+ fn validate_block_size(size: u32) -> Result {
if !(512..=bindings::PAGE_SIZE as u32).contains(&size) || !size.is_power_of_two() {
Err(error::code::EINVAL)
} else {