KVM: x86/xen: update wallclock region

Wallclock on Xen is written in the shared_info page.

To that purpose, export kvm_write_wall_clock() and pass on the GPA of
its location to populate the shared_info wall clock data.

Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index e9191dfffbbb3c35a341409b42db9fd02fd87dee..abc4c78a7aa47c3d037d4e2f7d254a1e3a78375c 100644 (file)
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1921,15 +1921,14 @@ static s64 get_kvmclock_base_ns(void)
 }
 #endif
 
-static void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock)
+void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs)
 {
        int version;
        int r;
        struct pvclock_wall_clock wc;
+       u32 wc_sec_hi;
        u64 wall_nsec;
 
-       kvm->arch.wall_clock = wall_clock;
-
        if (!wall_clock)
                return;
 
@@ -1958,6 +1957,12 @@ static void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock)
 
        kvm_write_guest(kvm, wall_clock, &wc, sizeof(wc));
 
+       if (sec_hi_ofs) {
+               wc_sec_hi = wall_nsec >> 32;
+               kvm_write_guest(kvm, wall_clock + sec_hi_ofs,
+                               &wc_sec_hi, sizeof(wc_sec_hi));
+       }
+
        version++;
        kvm_write_guest(kvm, wall_clock, &version, sizeof(version));
 }
@@ -3117,13 +3122,15 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
                if (!guest_pv_has(vcpu, KVM_FEATURE_CLOCKSOURCE2))
                        return 1;
 
-               kvm_write_wall_clock(vcpu->kvm, data);
+               vcpu->kvm->arch.wall_clock = data;
+               kvm_write_wall_clock(vcpu->kvm, data, 0);
                break;
        case MSR_KVM_WALL_CLOCK:
                if (!guest_pv_has(vcpu, KVM_FEATURE_CLOCKSOURCE))
                        return 1;
 
-               kvm_write_wall_clock(vcpu->kvm, data);
+               vcpu->kvm->arch.wall_clock = data;
+               kvm_write_wall_clock(vcpu->kvm, data, 0);
                break;
        case MSR_KVM_SYSTEM_TIME_NEW:
                if (!guest_pv_has(vcpu, KVM_FEATURE_CLOCKSOURCE2))

diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
index e7ca622a468f5f14538f10b6bbed473f30108b49..cf8778410015f9b9bda96ce957c6cfb8f1558893 100644 (file)
--- a/arch/x86/kvm/x86.h
+++ b/arch/x86/kvm/x86.h
@@ -246,6 +246,7 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu)
        return is_smm(vcpu) || kvm_x86_ops.apic_init_signal_blocked(vcpu);
 }
 
+void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs);
 void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip);
 
 void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr);

diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c
index c0fd54f1c12101748d498ecd64ad4cfb21ec2a55..2e4e98297364c04a12df39b9f415cc2bdeec1b12 100644 (file)
--- a/arch/x86/kvm/xen.c
+++ b/arch/x86/kvm/xen.c
@@ -47,6 +47,7 @@ static int kvm_xen_map_guest_page(struct kvm *kvm, struct kvm_host_map *map,
 static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t gfn)
 {
        gpa_t gpa = gfn_to_gpa(gfn);
+       int wc_ofs, sec_hi_ofs;
        int ret;
 
        ret = kvm_xen_map_guest_page(kvm, &kvm->arch.xen.shinfo_map,
@@ -55,6 +56,25 @@ static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t gfn)
        if (ret)
                return ret;
 
+       BUILD_BUG_ON(offsetof(struct compat_shared_info, wc) != 0x900);
+       BUILD_BUG_ON(offsetof(struct compat_shared_info, arch.wc_sec_hi) != 0x924);
+       BUILD_BUG_ON(offsetof(struct pvclock_vcpu_time_info, version) != 0);
+
+       /* 32-bit location by default */
+       wc_ofs = offsetof(struct compat_shared_info, wc);
+       sec_hi_ofs = offsetof(struct compat_shared_info, arch.wc_sec_hi);
+
+#ifdef CONFIG_64BIT
+       BUILD_BUG_ON(offsetof(struct shared_info, wc) != 0xc00);
+       BUILD_BUG_ON(offsetof(struct shared_info, wc_sec_hi) != 0xc0c);
+
+       if (kvm->arch.xen.long_mode) {
+               wc_ofs = offsetof(struct shared_info, wc);
+               sec_hi_ofs = offsetof(struct shared_info, wc_sec_hi);
+       }
+#endif
+
+       kvm_write_wall_clock(kvm, gpa + wc_ofs, sec_hi_ofs - wc_ofs);
        kvm_make_all_cpus_request(kvm, KVM_REQ_MASTERCLOCK_UPDATE);
 
        return 0;
@@ -69,7 +89,6 @@ void kvm_xen_setup_pvclock_page(struct kvm_vcpu *v)
        if (v->vcpu_id >= MAX_VIRT_CPUS)
                return;
 
-       BUILD_BUG_ON(offsetof(struct pvclock_vcpu_time_info, version) != 0);
        BUILD_BUG_ON(offsetof(struct shared_info, vcpu_info) != 0);
        BUILD_BUG_ON(offsetof(struct compat_shared_info, vcpu_info) != 0);
        BUILD_BUG_ON(sizeof(struct vcpu_info) != sizeof(struct compat_vcpu_info));

diff --git a/arch/x86/kvm/xen.h b/arch/x86/kvm/xen.h
index 0b6bfe4ee1083eff6e5dc2910cdac55dfc7e4081..4f73866b3d33e460a301947107fdad7435da1917 100644 (file)
--- a/arch/x86/kvm/xen.h
+++ b/arch/x86/kvm/xen.h
@@ -54,9 +54,7 @@ struct compat_shared_info {
        struct compat_vcpu_info vcpu_info[MAX_VIRT_CPUS];
        uint32_t evtchn_pending[sizeof(compat_ulong_t) * 8];
        uint32_t evtchn_mask[sizeof(compat_ulong_t) * 8];
-       uint32_t wc_version;
-       uint32_t wc_sec;
-       uint32_t wc_nsec;
+       struct pvclock_wall_clock wc;
        struct compat_arch_shared_info arch;
 
 };