scsi: be2iscsi: Add missing unlock for mbox_lock

Orabug: 25655127

Julia pointed out beiscsi_boot_get_sinfo does not unlock mbox_lock on
nonemb_cmd memory allocation failure.

Signed-off-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>

diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index ea6ffaeb919d2b19d4c77100497636cef0eb767e..59fe6d07aadc115ad470c9cf9616e58b4c5d7846 100644 (file)
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -1085,8 +1085,10 @@ unsigned int beiscsi_boot_get_sinfo(struct beiscsi_hba *phba)
        nonemb_cmd->va = pci_alloc_consistent(phba->ctrl.pdev,
                                              sizeof(nonemb_cmd->size),
                                              &nonemb_cmd->dma);
-       if (!nonemb_cmd->va)
+       if (!nonemb_cmd->va) {
+               mutex_unlock(&ctrl->mbox_lock);
                return 0;
+       }
 
        req = nonemb_cmd->va;
        memset(req, 0, sizeof(*req));