]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: rt1320: fix the range of patch code address
authorShuming Fan <shumingf@realtek.com>
Tue, 1 Oct 2024 07:18:36 +0000 (15:18 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 1 Oct 2024 11:14:44 +0000 (12:14 +0100)
>> sound/soc/codecs/rt1320-sdw.c:564:14:
warning: result of comparison of constant 4295491583 with expression of type 'unsigned int' is always false
[-Wtautological-constant-out-of-range-compare]
     564 |                                 if (addr > 0x10007ffff || addr < 0x10007000) {
         |                                     ~~~~ ^ ~~~~~~~~~~~
   1 warning generated.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410011159.InLKFd40-lkp@intel.com/
Signed-off-by: Shuming Fan <shumingf@realtek.com>
Link: https://patch.msgid.link/20241001071836.3719162-1-shumingf@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1320-sdw.c

index 2404de8ae03dbfe5e704fe1afef80b4082d88c4c..ebd6f09bd990e68c3a3bd33e9386d5cb2521586b 100644 (file)
@@ -561,7 +561,7 @@ static void rt1320_load_mcu_patch(struct rt1320_sdw_priv *rt1320)
                                val = (ptr[i + 4] & 0xff) | (ptr[i + 5] & 0xff) << 8 |
                                        (ptr[i + 6] & 0xff) << 16 | (ptr[i + 7] & 0xff) << 24;
 
-                               if (addr > 0x10007ffff || addr < 0x10007000) {
+                               if (addr > 0x10007fff || addr < 0x10007000) {
                                        dev_err(&slave->dev, "%s: the address 0x%x is wrong", __func__, addr);
                                        goto _exit_;
                                }