i40e: update error message when trying to add invalid filters

Re-word the error message displayed when adding a filter with an
invalid flow type. Additionally, report a distinct error message when
the IPv4 protocol is at fault.

Change-ID: Iba3d85b87f8d383c97c8bdd180df34a6adf3ee67
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index ebffca0cefac9e037efcc819e8a0d066beb621b6..d45f48c84ff7e4027d44108aeb9146ccb3ec03f5 100644 (file)
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -533,14 +533,15 @@ int i40e_add_del_fdir(struct i40e_vsi *vsi,
                        break;
                default:
                        /* We cannot support masking based on protocol */
-                       goto unsupported_flow;
+                       dev_info(&pf->pdev->dev, "Unsupported IPv4 protocol 0x%02x\n",
+                                input->ip4_proto);
+                       return -EINVAL;
                }
                break;
        default:
-unsupported_flow:
-               dev_info(&pf->pdev->dev, "Could not specify spec type %d\n",
+               dev_info(&pf->pdev->dev, "Unsupported flow type 0x%02x\n",
                         input->flow_type);
-               ret = -EINVAL;
+               return -EINVAL;
        }
 
        /* The buffer allocated here will be normally be freed by