]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: codecs: wm5100: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 8 Apr 2025 07:38:22 +0000 (09:38 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 13 Apr 2025 19:23:17 +0000 (20:23 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250408-gpiochip-set-rv-sound-v1-4-dd54b6ca1ef9@linaro.org
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm5100.c

index d9e5762324dfee685f6621b881f9bf88f884bc1a..fb5ed4ba7f60bc86b4fec267ad7153e3cb340d58 100644 (file)
@@ -2236,12 +2236,14 @@ static irqreturn_t wm5100_edge_irq(int irq, void *data)
 }
 
 #ifdef CONFIG_GPIOLIB
-static void wm5100_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static int wm5100_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                          int value)
 {
        struct wm5100_priv *wm5100 = gpiochip_get_data(chip);
 
-       regmap_update_bits(wm5100->regmap, WM5100_GPIO_CTRL_1 + offset,
-                          WM5100_GP1_LVL, !!value << WM5100_GP1_LVL_SHIFT);
+       return regmap_update_bits(wm5100->regmap, WM5100_GPIO_CTRL_1 + offset,
+                                 WM5100_GP1_LVL,
+                                 !!value << WM5100_GP1_LVL_SHIFT);
 }
 
 static int wm5100_gpio_direction_out(struct gpio_chip *chip,
@@ -2288,7 +2290,7 @@ static const struct gpio_chip wm5100_template_chip = {
        .label                  = "wm5100",
        .owner                  = THIS_MODULE,
        .direction_output       = wm5100_gpio_direction_out,
-       .set                    = wm5100_gpio_set,
+       .set_rv                 = wm5100_gpio_set,
        .direction_input        = wm5100_gpio_direction_in,
        .get                    = wm5100_gpio_get,
        .can_sleep              = 1,