btrfs: simplify WQ_HIGHPRI handling in struct btrfs_workqueue

Just let the one caller that wants optional WQ_HIGHPRI handling allocate
a separate btrfs_workqueue for that.  This allows to rename struct
__btrfs_workqueue to btrfs_workqueue, remove a pointer indirection and
separate allocation for all btrfs_workqueue users and generally simplify
the code.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
index 43c89952b7d25746f1a96cf1fba527d4624782b9..aac240430efe13167d3b1c0610d14c54d0dd16a5 100644 (file)
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-thread.c
@@ -15,13 +15,12 @@
 enum {
        WORK_DONE_BIT,
        WORK_ORDER_DONE_BIT,
-       WORK_HIGH_PRIO_BIT,
 };
 
 #define NO_THRESHOLD (-1)
 #define DFT_THRESHOLD (32)
 
-struct __btrfs_workqueue {
+struct btrfs_workqueue {
        struct workqueue_struct *normal_wq;
 
        /* File system this workqueue services */
@@ -48,12 +47,7 @@ struct __btrfs_workqueue {
        spinlock_t thres_lock;
 };
 
-struct btrfs_workqueue {
-       struct __btrfs_workqueue *normal;
-       struct __btrfs_workqueue *high;
-};
-
-struct btrfs_fs_info * __pure btrfs_workqueue_owner(const struct __btrfs_workqueue *wq)
+struct btrfs_fs_info * __pure btrfs_workqueue_owner(const struct btrfs_workqueue *wq)
 {
        return wq->fs_info;
 }
@@ -66,22 +60,22 @@ struct btrfs_fs_info * __pure btrfs_work_owner(const struct btrfs_work *work)
 bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq)
 {
        /*
-        * We could compare wq->normal->pending with num_online_cpus()
+        * We could compare wq->pending with num_online_cpus()
         * to support "thresh == NO_THRESHOLD" case, but it requires
         * moving up atomic_inc/dec in thresh_queue/exec_hook. Let's
         * postpone it until someone needs the support of that case.
         */
-       if (wq->normal->thresh == NO_THRESHOLD)
+       if (wq->thresh == NO_THRESHOLD)
                return false;
 
-       return atomic_read(&wq->normal->pending) > wq->normal->thresh * 2;
+       return atomic_read(&wq->pending) > wq->thresh * 2;
 }
 
-static struct __btrfs_workqueue *
-__btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info, const char *name,
-                       unsigned int flags, int limit_active, int thresh)
+struct btrfs_workqueue *btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info,
+                                             const char *name, unsigned int flags,
+                                             int limit_active, int thresh)
 {
-       struct __btrfs_workqueue *ret = kzalloc(sizeof(*ret), GFP_KERNEL);
+       struct btrfs_workqueue *ret = kzalloc(sizeof(*ret), GFP_KERNEL);
 
        if (!ret)
                return NULL;
@@ -105,12 +99,8 @@ __btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info, const char *name,
                ret->thresh = thresh;
        }
 
-       if (flags & WQ_HIGHPRI)
-               ret->normal_wq = alloc_workqueue("btrfs-%s-high", flags,
-                                                ret->current_active, name);
-       else
-               ret->normal_wq = alloc_workqueue("btrfs-%s", flags,
-                                                ret->current_active, name);
+       ret->normal_wq = alloc_workqueue("btrfs-%s", flags, ret->current_active,
+                                        name);
        if (!ret->normal_wq) {
                kfree(ret);
                return NULL;
@@ -119,41 +109,7 @@ __btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info, const char *name,
        INIT_LIST_HEAD(&ret->ordered_list);
        spin_lock_init(&ret->list_lock);
        spin_lock_init(&ret->thres_lock);
-       trace_btrfs_workqueue_alloc(ret, name, flags & WQ_HIGHPRI);
-       return ret;
-}
-
-static inline void
-__btrfs_destroy_workqueue(struct __btrfs_workqueue *wq);
-
-struct btrfs_workqueue *btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info,
-                                             const char *name,
-                                             unsigned int flags,
-                                             int limit_active,
-                                             int thresh)
-{
-       struct btrfs_workqueue *ret = kzalloc(sizeof(*ret), GFP_KERNEL);
-
-       if (!ret)
-               return NULL;
-
-       ret->normal = __btrfs_alloc_workqueue(fs_info, name,
-                                             flags & ~WQ_HIGHPRI,
-                                             limit_active, thresh);
-       if (!ret->normal) {
-               kfree(ret);
-               return NULL;
-       }
-
-       if (flags & WQ_HIGHPRI) {
-               ret->high = __btrfs_alloc_workqueue(fs_info, name, flags,
-                                                   limit_active, thresh);
-               if (!ret->high) {
-                       __btrfs_destroy_workqueue(ret->normal);
-                       kfree(ret);
-                       return NULL;
-               }
-       }
+       trace_btrfs_workqueue_alloc(ret, name);
        return ret;
 }
 
@@ -162,7 +118,7 @@ struct btrfs_workqueue *btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info,
  * This hook WILL be called in IRQ handler context,
  * so workqueue_set_max_active MUST NOT be called in this hook
  */
-static inline void thresh_queue_hook(struct __btrfs_workqueue *wq)
+static inline void thresh_queue_hook(struct btrfs_workqueue *wq)
 {
        if (wq->thresh == NO_THRESHOLD)
                return;
@@ -174,7 +130,7 @@ static inline void thresh_queue_hook(struct __btrfs_workqueue *wq)
  * This hook is called in kthread content.
  * So workqueue_set_max_active is called here.
  */
-static inline void thresh_exec_hook(struct __btrfs_workqueue *wq)
+static inline void thresh_exec_hook(struct btrfs_workqueue *wq)
 {
        int new_current_active;
        long pending;
@@ -217,7 +173,7 @@ out:
        }
 }
 
-static void run_ordered_work(struct __btrfs_workqueue *wq,
+static void run_ordered_work(struct btrfs_workqueue *wq,
                             struct btrfs_work *self)
 {
        struct list_head *list = &wq->ordered_list;
@@ -305,7 +261,7 @@ static void btrfs_work_helper(struct work_struct *normal_work)
 {
        struct btrfs_work *work = container_of(normal_work, struct btrfs_work,
                                               normal_work);
-       struct __btrfs_workqueue *wq;
+       struct btrfs_workqueue *wq = work->wq;
        int need_order = 0;
 
        /*
@@ -318,7 +274,6 @@ static void btrfs_work_helper(struct work_struct *normal_work)
         */
        if (work->ordered_func)
                need_order = 1;
-       wq = work->wq;
 
        trace_btrfs_work_sched(work);
        thresh_exec_hook(wq);
@@ -350,8 +305,7 @@ void btrfs_init_work(struct btrfs_work *work, btrfs_func_t func,
        work->flags = 0;
 }
 
-static inline void __btrfs_queue_work(struct __btrfs_workqueue *wq,
-                                     struct btrfs_work *work)
+void btrfs_queue_work(struct btrfs_workqueue *wq, struct btrfs_work *work)
 {
        unsigned long flags;
 
@@ -366,54 +320,22 @@ static inline void __btrfs_queue_work(struct __btrfs_workqueue *wq,
        queue_work(wq->normal_wq, &work->normal_work);
 }
 
-void btrfs_queue_work(struct btrfs_workqueue *wq,
-                     struct btrfs_work *work)
-{
-       struct __btrfs_workqueue *dest_wq;
-
-       if (test_bit(WORK_HIGH_PRIO_BIT, &work->flags) && wq->high)
-               dest_wq = wq->high;
-       else
-               dest_wq = wq->normal;
-       __btrfs_queue_work(dest_wq, work);
-}
-
-static inline void
-__btrfs_destroy_workqueue(struct __btrfs_workqueue *wq)
-{
-       destroy_workqueue(wq->normal_wq);
-       trace_btrfs_workqueue_destroy(wq);
-       kfree(wq);
-}
-
 void btrfs_destroy_workqueue(struct btrfs_workqueue *wq)
 {
        if (!wq)
                return;
-       if (wq->high)
-               __btrfs_destroy_workqueue(wq->high);
-       __btrfs_destroy_workqueue(wq->normal);
+       destroy_workqueue(wq->normal_wq);
+       trace_btrfs_workqueue_destroy(wq);
        kfree(wq);
 }
 
 void btrfs_workqueue_set_max(struct btrfs_workqueue *wq, int limit_active)
 {
-       if (!wq)
-               return;
-       wq->normal->limit_active = limit_active;
-       if (wq->high)
-               wq->high->limit_active = limit_active;
-}
-
-void btrfs_set_work_high_priority(struct btrfs_work *work)
-{
-       set_bit(WORK_HIGH_PRIO_BIT, &work->flags);
+       if (wq)
+               wq->limit_active = limit_active;
 }
 
 void btrfs_flush_workqueue(struct btrfs_workqueue *wq)
 {
-       if (wq->high)
-               flush_workqueue(wq->high->normal_wq);
-
-       flush_workqueue(wq->normal->normal_wq);
+       flush_workqueue(wq->normal_wq);
 }

diff --git a/fs/btrfs/async-thread.h b/fs/btrfs/async-thread.h
index 3204daa51b955734e10cea7be5f7df24824814de..07960529b360108310ab55562bfbe99eea251e53 100644 (file)
--- a/fs/btrfs/async-thread.h
+++ b/fs/btrfs/async-thread.h
@@ -11,8 +11,6 @@
 
 struct btrfs_fs_info;
 struct btrfs_workqueue;
-/* Internal use only */
-struct __btrfs_workqueue;
 struct btrfs_work;
 typedef void (*btrfs_func_t)(struct btrfs_work *arg);
 typedef void (*btrfs_work_func_t)(struct work_struct *arg);
@@ -25,7 +23,7 @@ struct btrfs_work {
        /* Don't touch things below */
        struct work_struct normal_work;
        struct list_head ordered_list;
-       struct __btrfs_workqueue *wq;
+       struct btrfs_workqueue *wq;
        unsigned long flags;
 };
 
@@ -40,9 +38,8 @@ void btrfs_queue_work(struct btrfs_workqueue *wq,
                      struct btrfs_work *work);
 void btrfs_destroy_workqueue(struct btrfs_workqueue *wq);
 void btrfs_workqueue_set_max(struct btrfs_workqueue *wq, int max);
-void btrfs_set_work_high_priority(struct btrfs_work *work);
 struct btrfs_fs_info * __pure btrfs_work_owner(const struct btrfs_work *work);
-struct btrfs_fs_info * __pure btrfs_workqueue_owner(const struct __btrfs_workqueue *wq);
+struct btrfs_fs_info * __pure btrfs_workqueue_owner(const struct btrfs_workqueue *wq);
 bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq);
 void btrfs_flush_workqueue(struct btrfs_workqueue *wq);
 

diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index dd23f78664f19b82d32d7a91fa825fb7aeb1e406..aa3aea042ec5656076da457b6d8239c427e48128 100644 (file)
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -847,6 +847,7 @@ struct btrfs_fs_info {
         * two
         */
        struct btrfs_workqueue *workers;
+       struct btrfs_workqueue *hipri_workers;
        struct btrfs_workqueue *delalloc_workers;
        struct btrfs_workqueue *flush_workers;
        struct btrfs_workqueue *endio_workers;

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index d70289ef581a2e900451d102903cb2db274c3f78..807e7b2728963ce45103335ce70bd3bbcd3ac714 100644 (file)
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -874,9 +874,9 @@ blk_status_t btrfs_wq_submit_bio(struct inode *inode, struct bio *bio,
        async->status = 0;
 
        if (op_is_sync(bio->bi_opf))
-               btrfs_set_work_high_priority(&async->work);
-
-       btrfs_queue_work(fs_info->workers, &async->work);
+               btrfs_queue_work(fs_info->hipri_workers, &async->work);
+       else
+               btrfs_queue_work(fs_info->workers, &async->work);
        return 0;
 }
 
@@ -2279,6 +2279,7 @@ static void btrfs_stop_all_workers(struct btrfs_fs_info *fs_info)
 {
        btrfs_destroy_workqueue(fs_info->fixup_workers);
        btrfs_destroy_workqueue(fs_info->delalloc_workers);
+       btrfs_destroy_workqueue(fs_info->hipri_workers);
        btrfs_destroy_workqueue(fs_info->workers);
        btrfs_destroy_workqueue(fs_info->endio_workers);
        btrfs_destroy_workqueue(fs_info->endio_raid56_workers);
@@ -2457,7 +2458,9 @@ static int btrfs_init_workqueues(struct btrfs_fs_info *fs_info)
        unsigned int flags = WQ_MEM_RECLAIM | WQ_FREEZABLE | WQ_UNBOUND;
 
        fs_info->workers =
-               btrfs_alloc_workqueue(fs_info, "worker",
+               btrfs_alloc_workqueue(fs_info, "worker", flags, max_active, 16);
+       fs_info->hipri_workers =
+               btrfs_alloc_workqueue(fs_info, "worker-high",
                                      flags | WQ_HIGHPRI, max_active, 16);
 
        fs_info->delalloc_workers =
@@ -2505,8 +2508,8 @@ static int btrfs_init_workqueues(struct btrfs_fs_info *fs_info)
        fs_info->discard_ctl.discard_workers =
                alloc_workqueue("btrfs_discard", WQ_UNBOUND | WQ_FREEZABLE, 1);
 
-       if (!(fs_info->workers && fs_info->delalloc_workers &&
-             fs_info->flush_workers &&
+       if (!(fs_info->workers && fs_info->hipri_workers &&
+             fs_info->delalloc_workers && fs_info->flush_workers &&
              fs_info->endio_workers && fs_info->endio_meta_workers &&
              fs_info->endio_meta_write_workers &&
              fs_info->endio_write_workers && fs_info->endio_raid56_workers &&

diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 206f44005c52a861e4f1c939b00ef91e222af039..2236024aca648e704b1e2910661b28d095a260d2 100644 (file)
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1903,6 +1903,7 @@ static void btrfs_resize_thread_pool(struct btrfs_fs_info *fs_info,
               old_pool_size, new_pool_size);
 
        btrfs_workqueue_set_max(fs_info->workers, new_pool_size);
+       btrfs_workqueue_set_max(fs_info->hipri_workers, new_pool_size);
        btrfs_workqueue_set_max(fs_info->delalloc_workers, new_pool_size);
        btrfs_workqueue_set_max(fs_info->caching_workers, new_pool_size);
        btrfs_workqueue_set_max(fs_info->endio_workers, new_pool_size);

diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
index f068ff30d6541fe835a614ae2d7fbd08ba8a276d..290f07eb050af5954ccad0307692928388c3f605 100644 (file)
--- a/include/trace/events/btrfs.h
+++ b/include/trace/events/btrfs.h
@@ -24,7 +24,7 @@ struct btrfs_free_cluster;
 struct map_lookup;
 struct extent_buffer;
 struct btrfs_work;
-struct __btrfs_workqueue;
+struct btrfs_workqueue;
 struct btrfs_qgroup_extent_record;
 struct btrfs_qgroup;
 struct extent_io_tree;
@@ -1457,42 +1457,36 @@ DEFINE_EVENT(btrfs__work, btrfs_ordered_sched,
        TP_ARGS(work)
 );
 
-DECLARE_EVENT_CLASS(btrfs__workqueue,
+DECLARE_EVENT_CLASS(btrfs_workqueue,
 
-       TP_PROTO(const struct __btrfs_workqueue *wq,
-                const char *name, int high),
+       TP_PROTO(const struct btrfs_workqueue *wq, const char *name),
 
-       TP_ARGS(wq, name, high),
+       TP_ARGS(wq, name),
 
        TP_STRUCT__entry_btrfs(
                __field(        const void *,   wq                      )
                __string(       name,   name                    )
-               __field(        int ,   high                    )
        ),
 
        TP_fast_assign_btrfs(btrfs_workqueue_owner(wq),
                __entry->wq             = wq;
                __assign_str(name, name);
-               __entry->high           = high;
        ),
 
-       TP_printk_btrfs("name=%s%s wq=%p", __get_str(name),
-                 __print_flags(__entry->high, "",
-                               {(WQ_HIGHPRI),  "-high"}),
+       TP_printk_btrfs("name=%s wq=%p", __get_str(name),
                  __entry->wq)
 );
 
-DEFINE_EVENT(btrfs__workqueue, btrfs_workqueue_alloc,
+DEFINE_EVENT(btrfs_workqueue, btrfs_workqueue_alloc,
 
-       TP_PROTO(const struct __btrfs_workqueue *wq,
-                const char *name, int high),
+       TP_PROTO(const struct btrfs_workqueue *wq, const char *name),
 
-       TP_ARGS(wq, name, high)
+       TP_ARGS(wq, name)
 );
 
-DECLARE_EVENT_CLASS(btrfs__workqueue_done,
+DECLARE_EVENT_CLASS(btrfs_workqueue_done,
 
-       TP_PROTO(const struct __btrfs_workqueue *wq),
+       TP_PROTO(const struct btrfs_workqueue *wq),
 
        TP_ARGS(wq),
 
@@ -1507,9 +1501,9 @@ DECLARE_EVENT_CLASS(btrfs__workqueue_done,
        TP_printk_btrfs("wq=%p", __entry->wq)
 );
 
-DEFINE_EVENT(btrfs__workqueue_done, btrfs_workqueue_destroy,
+DEFINE_EVENT(btrfs_workqueue_done, btrfs_workqueue_destroy,
 
-       TP_PROTO(const struct __btrfs_workqueue *wq),
+       TP_PROTO(const struct btrfs_workqueue *wq),
 
        TP_ARGS(wq)
 );