net: mdio: mux-meson-gxl: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/mdio/mdio-mux-meson-gxl.c b/drivers/net/mdio/mdio-mux-meson-gxl.c
index 76188575ca1fcf29b4b76942540cabdf9a48f82e..89554021b5ccc40a0dd494221e90d3ce8f755d2a 100644 (file)
--- a/drivers/net/mdio/mdio-mux-meson-gxl.c
+++ b/drivers/net/mdio/mdio-mux-meson-gxl.c
@@ -140,18 +140,16 @@ static int gxl_mdio_mux_probe(struct platform_device *pdev)
        return ret;
 }
 
-static int gxl_mdio_mux_remove(struct platform_device *pdev)
+static void gxl_mdio_mux_remove(struct platform_device *pdev)
 {
        struct gxl_mdio_mux *priv = platform_get_drvdata(pdev);
 
        mdio_mux_uninit(priv->mux_handle);
-
-       return 0;
 }
 
 static struct platform_driver gxl_mdio_mux_driver = {
        .probe          = gxl_mdio_mux_probe,
-       .remove         = gxl_mdio_mux_remove,
+       .remove_new     = gxl_mdio_mux_remove,
        .driver         = {
                .name   = "gxl-mdio-mux",
                .of_match_table = gxl_mdio_mux_match,