]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
crypto: rockchip - fix to check return value
authorKilian Zinnecker <kilian.zinnecker@mail.de>
Sun, 18 Feb 2024 22:16:58 +0000 (23:16 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 24 Feb 2024 00:41:20 +0000 (08:41 +0800)
crypto_engine_alloc_init may fail, e.g., as result of a fail of
devm_kzalloc or kthread_create_worker. Other drivers (e.g.,
amlogic-gxl-core.c, aspeed-acry.c, aspeed-hace.c, jr.c, etc.) check
crypto_engine_alloc_init's return value and return -ENOMEM in case
a NULL pointer is returned. This patch inserts a corresponding
return value check to rk3288_crypto.c.

Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/rockchip/rk3288_crypto.c

index 70edf40bc523c0932bf8abb0b36682b0549d2ed3..f74b3c81ba6df73397a7a677a393a07b06aaf3cc 100644 (file)
@@ -371,6 +371,11 @@ static int rk_crypto_probe(struct platform_device *pdev)
        }
 
        crypto_info->engine = crypto_engine_alloc_init(&pdev->dev, true);
+       if (!crypto_info->engine) {
+               err = -ENOMEM;
+               goto err_crypto;
+       }
+
        crypto_engine_start(crypto_info->engine);
        init_completion(&crypto_info->complete);