]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: temperature: mlx90635: Fix ERR_PTR dereference in mlx90635_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Mon, 13 May 2024 20:34:27 +0000 (13:34 -0700)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 27 May 2024 08:49:20 +0000 (09:49 +0100)
When devm_regmap_init_i2c() fails, regmap_ee could be error pointer,
instead of checking for IS_ERR(regmap_ee), regmap is checked which looks
like a copy paste error.

Fixes: a1d1ba5e1c28 ("iio: temperature: mlx90635 MLX90635 IR Temperature sensor")
Reviewed-by: Crt Mori<cmo@melexis.com>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20240513203427.3208696-1-harshit.m.mogalapalli@oracle.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/temperature/mlx90635.c

index 1f5c962c1818ff19d229109257d5f7e0a493b54c..f7f88498ba0e8d199888ab2992d75001235cfbb4 100644 (file)
@@ -947,9 +947,9 @@ static int mlx90635_probe(struct i2c_client *client)
                                     "failed to allocate regmap\n");
 
        regmap_ee = devm_regmap_init_i2c(client, &mlx90635_regmap_ee);
-       if (IS_ERR(regmap))
-               return dev_err_probe(&client->dev, PTR_ERR(regmap),
-                                    "failed to allocate regmap\n");
+       if (IS_ERR(regmap_ee))
+               return dev_err_probe(&client->dev, PTR_ERR(regmap_ee),
+                                    "failed to allocate EEPROM regmap\n");
 
        mlx90635 = iio_priv(indio_dev);
        i2c_set_clientdata(client, indio_dev);