drm/msm/mdp5: Simplify LM <-> PP mapping

PingPong ID for a Layer Mixer is already contained in
mdp5_hw_mixer.

This avoids the need to retrieve PP ID using macros

Signed-off-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c
index 2e6ceafbd3e2455b3dde9f5603030e006247f561..fd3cb45976f3492a8c90dd48e9914ebfa7bc169d 100644 (file)
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c
@@ -52,7 +52,7 @@ static int pingpong_tearcheck_setup(struct drm_encoder *encoder,
        u32 total_lines_x100, vclks_line, cfg;
        long vsync_clk_speed;
        struct mdp5_hw_mixer *mixer = mdp5_crtc_get_mixer(encoder->crtc);
-       int pp_id = GET_PING_PONG_ID(mixer->lm);
+       int pp_id = mixer->pp;
 
        if (IS_ERR_OR_NULL(mdp5_kms->vsync_clk)) {
                dev_err(dev, "vsync_clk is not initialized\n");
@@ -96,7 +96,7 @@ static int pingpong_tearcheck_enable(struct drm_encoder *encoder)
 {
        struct mdp5_kms *mdp5_kms = get_kms(encoder);
        struct mdp5_hw_mixer *mixer = mdp5_crtc_get_mixer(encoder->crtc);
-       int pp_id = GET_PING_PONG_ID(mixer->lm);
+       int pp_id = mixer->pp;
        int ret;
 
        ret = clk_set_rate(mdp5_kms->vsync_clk,
@@ -122,7 +122,7 @@ static void pingpong_tearcheck_disable(struct drm_encoder *encoder)
 {
        struct mdp5_kms *mdp5_kms = get_kms(encoder);
        struct mdp5_hw_mixer *mixer = mdp5_crtc_get_mixer(encoder->crtc);
-       int pp_id = GET_PING_PONG_ID(mixer->lm);
+       int pp_id = mixer->pp;
 
        mdp5_write(mdp5_kms, REG_MDP5_PP_TEAR_CHECK_EN(pp_id), 0);
        clk_disable_unprepare(mdp5_kms->vsync_clk);

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
index ffdb31c4419ffaf86fb7e743a0b527ccf3c039e7..804777d925b112348a32925c2d3497fab78d0630 100644 (file)
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
@@ -755,15 +755,14 @@ void mdp5_crtc_set_pipeline(struct drm_crtc *crtc,
        struct mdp5_crtc *mdp5_crtc = to_mdp5_crtc(crtc);
        struct mdp5_kms *mdp5_kms = get_kms(crtc);
        struct mdp5_hw_mixer *mixer = mdp5_crtc->mixer;
-       uint32_t lm = mixer->lm;
 
        /* now that we know what irq's we want: */
        mdp5_crtc->err.irqmask = intf2err(intf->num);
-       mdp5_crtc->vblank.irqmask = intf2vblank(lm, intf);
+       mdp5_crtc->vblank.irqmask = intf2vblank(mixer, intf);
 
        if ((intf->type == INTF_DSI) &&
                (intf->mode == MDP5_INTF_DSI_MODE_COMMAND)) {
-               mdp5_crtc->pp_done.irqmask = lm2ppdone(lm);
+               mdp5_crtc->pp_done.irqmask = lm2ppdone(mixer);
                mdp5_crtc->pp_done.irq = mdp5_crtc_pp_done_irq;
                mdp5_crtc->cmd_mode = true;
        } else {

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c
index 68d048f040f00e13482b1dcf375b72fc0b7548cb..c2c204e6ea3bc5f7d59a23a1f21af38900a37c99 100644 (file)
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c
@@ -238,7 +238,7 @@ static void mdp5_vid_encoder_disable(struct drm_encoder *encoder)
         * the settings changes for the new modeset (like new
         * scanout buffer) don't latch properly..
         */
-       mdp_irq_wait(&mdp5_kms->base, intf2vblank(mixer->lm, intf));
+       mdp_irq_wait(&mdp5_kms->base, intf2vblank(mixer, intf));
 
        bs_set(mdp5_encoder, 0);
 

diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h
index 13d9ccf378117017944ca2a6aa2f8a361445fe23..5a1ce871f5eb144a05dc03ad8e46e78deff56271 100644 (file)
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h
@@ -201,8 +201,8 @@ static inline uint32_t intf2err(int intf_num)
        }
 }
 
-#define GET_PING_PONG_ID(layer_mixer)  ((layer_mixer == 5) ? 3 : layer_mixer)
-static inline uint32_t intf2vblank(int lm, struct mdp5_interface *intf)
+static inline uint32_t intf2vblank(struct mdp5_hw_mixer *mixer,
+                                  struct mdp5_interface *intf)
 {
        /*
         * In case of DSI Command Mode, the Ping Pong's read pointer IRQ
@@ -212,7 +212,7 @@ static inline uint32_t intf2vblank(int lm, struct mdp5_interface *intf)
 
        if ((intf->type == INTF_DSI) &&
                        (intf->mode == MDP5_INTF_DSI_MODE_COMMAND))
-               return MDP5_IRQ_PING_PONG_0_RD_PTR << GET_PING_PONG_ID(lm);
+               return MDP5_IRQ_PING_PONG_0_RD_PTR << mixer->pp;
 
        if (intf->type == INTF_WB)
                return MDP5_IRQ_WB_2_DONE;
@@ -226,9 +226,9 @@ static inline uint32_t intf2vblank(int lm, struct mdp5_interface *intf)
        }
 }
 
-static inline uint32_t lm2ppdone(int lm)
+static inline uint32_t lm2ppdone(struct mdp5_hw_mixer *mixer)
 {
-       return MDP5_IRQ_PING_PONG_0_DONE << GET_PING_PONG_ID(lm);
+       return MDP5_IRQ_PING_PONG_0_DONE << mixer->pp;
 }
 
 int mdp5_disable(struct mdp5_kms *mdp5_kms);