]> www.infradead.org Git - users/borneoa/openocd-next.git/commitdiff
target: don't free working areas during 'configure -chain-position'
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 5 Apr 2025 23:20:44 +0000 (01:20 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 19 Apr 2025 09:21:17 +0000 (09:21 +0000)
Since commit ef1cfb23947b ("Duane Ellis: "target as an [tcl]
object" feature.") merged in 2008, the commands:
$target_name configure -chain-position ...
target create ... -chain-position ...
cause the allocated working area to be freed.

There is no reason for this, it is probably caused by an incorrect
copy/paste from the author.

Drop the call to target_free_all_working_areas().

Change-Id: I61a9303afe7fee6953669218330635c0b965b20d
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8825
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
src/target/target.c

index 8c5c8e5e303d15f700af77c086ba46d03f036de9..36ad0eec833cff430813bb5ace6d7a002f3e5703 100644 (file)
@@ -5128,7 +5128,6 @@ no_params:
                                        return JIM_ERR;
                                }
 
-                               target_free_all_working_areas(target);
                                e = jim_getopt_obj(goi, &o_t);
                                if (e != JIM_OK)
                                        return e;