RDMA/hns: Fix usage of bitmap allocation functions return values

hns bitmap allocation functions return 0 on success and -1 on failure.
Callers of these functions wrongly used their return value as an errno,
fix that by making a proper conversion.

Fixes: a598c6f4c5a8 ("IB/hns: Simplify function of pd alloc and qp alloc")
Signed-off-by: Gal Pressman <pressmangal@gmail.com>
Acked-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/hw/hns/hns_roce_pd.c b/drivers/infiniband/hw/hns/hns_roce_pd.c
index b9f2c871ff9a688f9b71783637edbf445b009105..e11c149da04d55f29df784e7aa90ac44f418ee9a 100644 (file)
--- a/drivers/infiniband/hw/hns/hns_roce_pd.c
+++ b/drivers/infiniband/hw/hns/hns_roce_pd.c
@@ -37,7 +37,7 @@
 
 static int hns_roce_pd_alloc(struct hns_roce_dev *hr_dev, unsigned long *pdn)
 {
-       return hns_roce_bitmap_alloc(&hr_dev->pd_bitmap, pdn);
+       return hns_roce_bitmap_alloc(&hr_dev->pd_bitmap, pdn) ? -ENOMEM : 0;
 }
 
 static void hns_roce_pd_free(struct hns_roce_dev *hr_dev, unsigned long pdn)

diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c
index c1dbddcd58c9bb55868de4aeb576812939dc77a7..efb7e961ca6510eabaf73711b29bd0c4f37defbe 100644 (file)
--- a/drivers/infiniband/hw/hns/hns_roce_qp.c
+++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
@@ -115,7 +115,10 @@ static int hns_roce_reserve_range_qp(struct hns_roce_dev *hr_dev, int cnt,
 {
        struct hns_roce_qp_table *qp_table = &hr_dev->qp_table;
 
-       return hns_roce_bitmap_alloc_range(&qp_table->bitmap, cnt, align, base);
+       return hns_roce_bitmap_alloc_range(&qp_table->bitmap, cnt, align,
+                                          base) ?
+                      -ENOMEM :
+                      0;
 }
 
 enum hns_roce_qp_state to_hns_roce_state(enum ib_qp_state state)