]> www.infradead.org Git - qemu-nvme.git/commitdiff
tcg: Fix documentation for tcg_constant_* vs tcg_temp_free_*
authorRichard Henderson <richard.henderson@linaro.org>
Thu, 10 Jun 2021 16:32:40 +0000 (09:32 -0700)
committerRichard Henderson <richard.henderson@linaro.org>
Mon, 14 Jun 2021 00:42:40 +0000 (17:42 -0700)
At some point during the development of tcg_constant_*, I changed
my mind about whether such temps should be able to be passed to
tcg_temp_free_*.  The final version committed allows this, but the
commentary was not updated to match.

Fixes: c0522136adf
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
include/tcg/tcg.h

index 1d056ed0ed2f2b18a5d34655624084ae34213f9f..064dab383bcdd2204a146a0970a50792c4e71b60 100644 (file)
@@ -1095,7 +1095,8 @@ TCGv_vec tcg_const_ones_vec_matching(TCGv_vec);
 
 /*
  * Locate or create a read-only temporary that is a constant.
- * This kind of temporary need not and should not be freed.
+ * This kind of temporary need not be freed, but for convenience
+ * will be silently ignored by tcg_temp_free_*.
  */
 TCGTemp *tcg_constant_internal(TCGType type, int64_t val);