]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
gpio: fix uninit-value in swnode_find_gpio
authorSuraj Sonawane <surajsonawane0215@gmail.com>
Sat, 26 Oct 2024 09:06:42 +0000 (14:36 +0530)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 31 Oct 2024 12:39:25 +0000 (13:39 +0100)
Fix an issue detected by the Smatch tool:

drivers/gpio/gpiolib-swnode.c:78 swnode_find_gpio() error:
uninitialized symbol 'ret'.

The issue occurs because the 'ret' variable may be used without
initialization if the for_each_gpio_property_name loop does not run.
This could lead to returning an undefined value, causing unpredictable
behavior.

Initialize 'ret' to 0 before the loop to ensure the function
returns an error code if no properties are parsed, maintaining proper
error handling.

Fixes: 9e4c6c1ad ("Merge tag 'io_uring-6.12-20241011' of git://git.kernel.dk/linux")
Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
Link: https://lore.kernel.org/r/20241026090642.28633-1-surajsonawane0215@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib-swnode.c

index 2b2dd7e92211dcd82c168c77d832b0cb2dae5091..51d2475c05c57c7e9922dd534adf15c4bb3d2b1b 100644 (file)
@@ -64,7 +64,7 @@ struct gpio_desc *swnode_find_gpio(struct fwnode_handle *fwnode,
        struct fwnode_reference_args args;
        struct gpio_desc *desc;
        char propname[32]; /* 32 is max size of property name */
-       int ret;
+       int ret = 0;
 
        swnode = to_software_node(fwnode);
        if (!swnode)