]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
mmc: mmc_spi: allow for spi controllers incapable of getting as low as 400k
authorConor Dooley <conor.dooley@microchip.com>
Tue, 25 Jun 2024 12:33:21 +0000 (13:33 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 8 Jul 2024 09:34:57 +0000 (11:34 +0200)
Some controllers may not be able to reach a bus clock as low as 400 KHz
due to a lack of sufficient divisors. In these cases, the SD card slot
becomes non-functional as Linux continuously attempts to set the bus
clock to 400 KHz. If the controller is incapable of getting that low,
set its minimum frequency instead. While this may eliminate some SD
cards, it allows those capable of operating at the controller's minimum
frequency to be used.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20240625-gigantic-frown-1ef4afa3e6fa@wendy
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mmc_spi.c

index 09d7a6a0dc1aab68dfba5cc836e71e493b6e36c3..c9caa1ece7ef91ec94b97a6879315542f3264d05 100644 (file)
@@ -1208,7 +1208,10 @@ static int mmc_spi_probe(struct spi_device *spi)
         * that's the only reason not to use a few MHz for f_min (until
         * the upper layer reads the target frequency from the CSD).
         */
-       mmc->f_min = 400000;
+       if (spi->controller->min_speed_hz > 400000)
+               dev_warn(&spi->dev,"Controller unable to reduce bus clock to 400 KHz\n");
+
+       mmc->f_min = max(spi->controller->min_speed_hz, 400000);
        mmc->f_max = spi->max_speed_hz;
 
        host = mmc_priv(mmc);