]> www.infradead.org Git - users/hch/misc.git/commitdiff
eth: fbnic: fix csr boundary for RPM RAM section
authorMohsin Bashir <mohsin.bashr@gmail.com>
Wed, 18 Dec 2024 23:25:58 +0000 (15:25 -0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 Dec 2024 17:50:14 +0000 (09:50 -0800)
The CSR dump support leverages the FBNIC_BOUNDS macro, which pads the end
condition for each section by adding an offset of 1. However, the RPC RAM
section, which is dumped differently from other sections, does not rely
on this macro and instead directly uses end boundary address. Hence,
subtracting 1 from the end address results in skipping a register.

Fixes 3d12862b216d (“eth: fbnic: Add support to dump registers”)
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/20241218232614.439329-1-mohsin.bashr@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/meta/fbnic/fbnic_csr.c

index 2118901b25e91c71d80ad085d009eeffd1363667..aeb9f333f4c7a36d0dd961e8edd07c1f7367a3a1 100644 (file)
@@ -64,7 +64,7 @@ static void fbnic_csr_get_regs_rpc_ram(struct fbnic_dev *fbd, u32 **data_p)
        u32 i, j;
 
        *(data++) = start;
-       *(data++) = end - 1;
+       *(data++) = end;
 
        /* FBNIC_RPC_TCAM_ACT */
        for (i = 0; i < FBNIC_RPC_TCAM_ACT_NUM_ENTRIES; i++) {