]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
i2c: viperboard: Replace dev_err() with dev_err_probe() in probe function
authorEnrico Zanda <e.zanda1@gmail.com>
Tue, 15 Apr 2025 18:34:43 +0000 (20:34 +0200)
committerAndi Shyti <andi@smida.it>
Mon, 19 May 2025 20:23:55 +0000 (22:23 +0200)
This simplifies the code while improving log.

Signed-off-by: Enrico Zanda <e.zanda1@gmail.com>
Link: https://lore.kernel.org/r/20250415183447.396277-7-e.zanda1@gmail.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-viperboard.c

index 503e2f4d6f8449f1d9cceb23e3f0f2b8ccfb76a6..7523e7c02271071e239e97575e6bbf4139bf3385 100644 (file)
@@ -384,15 +384,13 @@ static int vprbrd_i2c_probe(struct platform_device *pdev)
                        VPRBRD_USB_REQUEST_I2C_FREQ, VPRBRD_USB_TYPE_OUT,
                        0x0000, 0x0000, &vb_i2c->bus_freq_param, 1,
                        VPRBRD_USB_TIMEOUT_MS);
-               if (ret != 1) {
-                       dev_err(&pdev->dev, "failure setting i2c_bus_freq to %d\n",
-                               i2c_bus_freq);
-                       return -EIO;
-               }
+               if (ret != 1)
+                       return dev_err_probe(&pdev->dev, -EIO,
+                                            "failure setting i2c_bus_freq to %d\n",
+                                            i2c_bus_freq);
        } else {
-               dev_err(&pdev->dev,
-                       "invalid i2c_bus_freq setting:%d\n", i2c_bus_freq);
-               return -EIO;
+               return dev_err_probe(&pdev->dev, -EIO,
+                                    "invalid i2c_bus_freq setting:%d\n", i2c_bus_freq);
        }
 
        vb_i2c->i2c.dev.parent = &pdev->dev;