net: txgbe: Fix memleak in txgbe_calc_eeprom_checksum()

eeprom_ptrs should be freed before returned.

Fixes: 049fe5365324 ("net: txgbe: Add operations to interact with firmware")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c
index 0b1032195859aff599f47b55d7d7c9dce9f286ba..9cf5fe33118ee8a6eb2cff62a7799d76b94e5555 100644 (file)
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c
@@ -183,6 +183,7 @@ static int txgbe_calc_eeprom_checksum(struct txgbe_hw *hw, u16 *checksum)
                                                  eeprom_ptrs);
                if (status != 0) {
                        wx_err(wxhw, "Failed to read EEPROM image\n");
+                       kvfree(eeprom_ptrs);
                        return status;
                }
                local_buffer = eeprom_ptrs;
@@ -196,13 +197,13 @@ static int txgbe_calc_eeprom_checksum(struct txgbe_hw *hw, u16 *checksum)
                if (i != wxhw->eeprom.sw_region_offset + TXGBE_EEPROM_CHECKSUM)
                        *checksum += local_buffer[i];
 
+       if (eeprom_ptrs)
+               kvfree(eeprom_ptrs);
+
        *checksum = TXGBE_EEPROM_SUM - *checksum;
        if (*checksum < 0)
                return -EINVAL;
 
-       if (eeprom_ptrs)
-               kvfree(eeprom_ptrs);
-
        return 0;
 }