]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
rtase: Corrects error handling of the rtase_check_mac_version_valid()
authorJustin Lai <justinlai0215@realtek.com>
Wed, 20 Nov 2024 07:56:24 +0000 (15:56 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 26 Nov 2024 09:12:58 +0000 (10:12 +0100)
Previously, when the hardware version ID was determined to be invalid,
only an error message was printed without any further handling. Therefore,
this patch makes the necessary corrections to address this.

Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
Signed-off-by: Justin Lai <justinlai0215@realtek.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/realtek/rtase/rtase_main.c

index c1782e32f9c6a37ef3afecd70ef2d5d082682693..de7f11232593fa0fdf174de3961b617f1043349e 100644 (file)
@@ -2122,6 +2122,7 @@ static int rtase_init_one(struct pci_dev *pdev,
                dev_err(&pdev->dev,
                        "unknown chip version: 0x%08x, contact rtase maintainers (see MAINTAINERS file)\n",
                        tp->hw_ver);
+               goto err_out_release_board;
        }
 
        rtase_init_software_variable(pdev, tp);
@@ -2196,6 +2197,7 @@ err_out_del_napi:
                netif_napi_del(&ivec->napi);
        }
 
+err_out_release_board:
        rtase_release_board(pdev, dev, ioaddr);
 
        return ret;