net: stmmac: ingenic: convert to use phy_interface

dwmac-ingenic uses only MII, RMII, GMII or RGMII interface modes, none
of which require any kind of conversion between the MAC and external
world. Thus, mac_interface and phy_interface will be the same.

Convert dwmac-ingenic to use phy_interface when determining the
interface mode that the dwmac core should be configured to at reset,
rather than mac_interface.

Also convert the error prints to use phy_modes() and terminate with a
newline so that we get a human readable string rather than a number for
the interface mode.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1uytpQ-00000006H2L-2Jzb@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c
index 15abe214131f8aa359457e204cd67de97841d12d..c1670f6bae145d3cf71a19bd2645fd300513f1a1 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c
@@ -90,7 +90,7 @@ static int jz4775_mac_set_mode(struct plat_stmmacenet_data *plat_dat)
        struct ingenic_mac *mac = plat_dat->bsp_priv;
        unsigned int val;
 
-       switch (plat_dat->mac_interface) {
+       switch (plat_dat->phy_interface) {
        case PHY_INTERFACE_MODE_MII:
                val = FIELD_PREP(MACPHYC_TXCLK_SEL_MASK, MACPHYC_TXCLK_SEL_INPUT) |
                          FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_MII);
@@ -119,7 +119,8 @@ static int jz4775_mac_set_mode(struct plat_stmmacenet_data *plat_dat)
                break;
 
        default:
-               dev_err(mac->dev, "Unsupported interface %d", plat_dat->mac_interface);
+               dev_err(mac->dev, "Unsupported interface %s\n",
+                       phy_modes(plat_dat->phy_interface));
                return -EINVAL;
        }
 
@@ -131,13 +132,14 @@ static int x1000_mac_set_mode(struct plat_stmmacenet_data *plat_dat)
 {
        struct ingenic_mac *mac = plat_dat->bsp_priv;
 
-       switch (plat_dat->mac_interface) {
+       switch (plat_dat->phy_interface) {
        case PHY_INTERFACE_MODE_RMII:
                dev_dbg(mac->dev, "MAC PHY Control Register: PHY_INTERFACE_MODE_RMII\n");
                break;
 
        default:
-               dev_err(mac->dev, "Unsupported interface %d", plat_dat->mac_interface);
+               dev_err(mac->dev, "Unsupported interface %s\n",
+                       phy_modes(plat_dat->phy_interface));
                return -EINVAL;
        }
 
@@ -150,14 +152,15 @@ static int x1600_mac_set_mode(struct plat_stmmacenet_data *plat_dat)
        struct ingenic_mac *mac = plat_dat->bsp_priv;
        unsigned int val;
 
-       switch (plat_dat->mac_interface) {
+       switch (plat_dat->phy_interface) {
        case PHY_INTERFACE_MODE_RMII:
                val = FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_RMII);
                dev_dbg(mac->dev, "MAC PHY Control Register: PHY_INTERFACE_MODE_RMII\n");
                break;
 
        default:
-               dev_err(mac->dev, "Unsupported interface %d", plat_dat->mac_interface);
+               dev_err(mac->dev, "Unsupported interface %s\n",
+                       phy_modes(plat_dat->phy_interface));
                return -EINVAL;
        }
 
@@ -170,7 +173,7 @@ static int x1830_mac_set_mode(struct plat_stmmacenet_data *plat_dat)
        struct ingenic_mac *mac = plat_dat->bsp_priv;
        unsigned int val;
 
-       switch (plat_dat->mac_interface) {
+       switch (plat_dat->phy_interface) {
        case PHY_INTERFACE_MODE_RMII:
                val = FIELD_PREP(MACPHYC_MODE_SEL_MASK, MACPHYC_MODE_SEL_RMII) |
                          FIELD_PREP(MACPHYC_PHY_INFT_MASK, MACPHYC_PHY_INFT_RMII);
@@ -178,7 +181,8 @@ static int x1830_mac_set_mode(struct plat_stmmacenet_data *plat_dat)
                break;
 
        default:
-               dev_err(mac->dev, "Unsupported interface %d", plat_dat->mac_interface);
+               dev_err(mac->dev, "Unsupported interface %s\n",
+                       phy_modes(plat_dat->phy_interface));
                return -EINVAL;
        }
 
@@ -191,7 +195,7 @@ static int x2000_mac_set_mode(struct plat_stmmacenet_data *plat_dat)
        struct ingenic_mac *mac = plat_dat->bsp_priv;
        unsigned int val;
 
-       switch (plat_dat->mac_interface) {
+       switch (plat_dat->phy_interface) {
        case PHY_INTERFACE_MODE_RMII:
                val = FIELD_PREP(MACPHYC_TX_SEL_MASK, MACPHYC_TX_SEL_ORIGIN) |
                          FIELD_PREP(MACPHYC_RX_SEL_MASK, MACPHYC_RX_SEL_ORIGIN) |
@@ -221,7 +225,8 @@ static int x2000_mac_set_mode(struct plat_stmmacenet_data *plat_dat)
                break;
 
        default:
-               dev_err(mac->dev, "Unsupported interface %d", plat_dat->mac_interface);
+               dev_err(mac->dev, "Unsupported interface %s\n",
+                       phy_modes(plat_dat->phy_interface));
                return -EINVAL;
        }