net: hostap: fix function cast warning

gcc -Wextra complains about the function type cast:

drivers/net/wireless/intersil/hostap/hostap_hw.c:3173:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]

Avoid this by just using the regular tasklet_setup() function instead
of the incorrect homegrown version.

Fixes: 7433c9690318 ("intersil: convert tasklets to use new tasklet_setup() API")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201026213040.3889546-2-arnd@kernel.org

diff --git a/drivers/net/wireless/intersil/hostap/hostap_hw.c b/drivers/net/wireless/intersil/hostap/hostap_hw.c
index 22cfb64526448f07181f0a2bfc68100572c34c65..9a19046217df68c44493db5792040e3cd5507d2c 100644 (file)
--- a/drivers/net/wireless/intersil/hostap/hostap_hw.c
+++ b/drivers/net/wireless/intersil/hostap/hostap_hw.c
@@ -3169,22 +3169,15 @@ prism2_init_local_data(struct prism2_helper_functions *funcs, int card_idx,
 
        /* Initialize tasklets for handling hardware IRQ related operations
         * outside hw IRQ handler */
-#define HOSTAP_TASKLET_INIT(q, f, d) \
-do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \
-while (0)
-       HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet,
-                           (unsigned long) local);
-
-       HOSTAP_TASKLET_INIT(&local->info_tasklet, hostap_info_tasklet,
-                           (unsigned long) local);
+       tasklet_setup(&local->bap_tasklet, hostap_bap_tasklet);
+       tasklet_setup(&local->info_tasklet, hostap_info_tasklet);
        hostap_info_init(local);
 
-       HOSTAP_TASKLET_INIT(&local->rx_tasklet,
-                           hostap_rx_tasklet, (unsigned long) local);
+       tasklet_setup(&local->rx_tasklet, hostap_rx_tasklet);
        skb_queue_head_init(&local->rx_list);
 
-       HOSTAP_TASKLET_INIT(&local->sta_tx_exc_tasklet,
-                           hostap_sta_tx_exc_tasklet, (unsigned long) local);
+       tasklet_setup(&local->sta_tx_exc_tasklet,
+                           hostap_sta_tx_exc_tasklet);
        skb_queue_head_init(&local->sta_tx_exc_list);
 
        INIT_LIST_HEAD(&local->cmd_queue);