]> www.infradead.org Git - users/willy/xarray.git/commitdiff
mm/damon/core-test: test only vaddr case on ops registration test
authorSeongJae Park <sj@kernel.org>
Tue, 27 Aug 2024 03:03:31 +0000 (20:03 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 4 Sep 2024 04:15:57 +0000 (21:15 -0700)
DAMON ops registration kunit test tests both vaddr and paddr use cases in
parts of the whole test cases.  Basically testing only one ops use case is
enough.  Do the test with only vaddr use case.

Link: https://lkml.kernel.org/r/20240827030336.7930-5-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: David Gow <davidgow@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core-test.h

index 0cee634f354455928e4e5c8a944fcf9e0e6aaebb..ef36d586d6ee6e3173afb6fbbc708841a7029445 100644 (file)
@@ -246,16 +246,12 @@ static void damon_test_split_regions_of(struct kunit *test)
 static void damon_test_ops_registration(struct kunit *test)
 {
        struct damon_ctx *c = damon_new_ctx();
-       struct damon_operations ops, bak;
+       struct damon_operations ops = {.id = DAMON_OPS_VADDR}, bak;
 
-       /* DAMON_OPS_{V,P}ADDR are registered on subsys_initcall */
+       /* DAMON_OPS_VADDR is registered on subsys_initcall */
        KUNIT_EXPECT_EQ(test, damon_select_ops(c, DAMON_OPS_VADDR), 0);
-       KUNIT_EXPECT_EQ(test, damon_select_ops(c, DAMON_OPS_PADDR), 0);
 
        /* Double-registration is prohibited */
-       ops.id = DAMON_OPS_VADDR;
-       KUNIT_EXPECT_EQ(test, damon_register_ops(&ops), -EINVAL);
-       ops.id = DAMON_OPS_PADDR;
        KUNIT_EXPECT_EQ(test, damon_register_ops(&ops), -EINVAL);
 
        /* Unknown ops id cannot be registered */