]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
arm64: dts: qcom: sm8650: correct MDSS interconnects
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sat, 26 Oct 2024 17:59:41 +0000 (20:59 +0300)
committerBjorn Andersson <andersson@kernel.org>
Thu, 26 Dec 2024 22:43:30 +0000 (16:43 -0600)
SM8650 lists two interconnects for the display subsystem, mdp0-mem
(between MDP and LLCC) and mdp1-mem (between LLCC and EBI, memory).
The second interconnect is a misuse. mdpN-mem paths should be used for
several outboud MDP interconnects rather than the path between LLCC and
memory. This kind of misuse can result in bandwidth underflows, possibly
degrading picture quality as the required memory bandwidth is divided
between all mdpN-mem paths (and LLCC-EBI should not be a part of such
division).

Drop the second path and use direct MDP-EBI path for mdp0-mem until we
support separate MDP-LLCC and LLCC-EBI paths.

Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes")
Cc: stable@kernel.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241026-fix-sm8x50-mdp-icc-v2-2-fd8ddf755acc@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sm8650.dtsi

index c76c0038c35ab048c88be9870b14c3a0b24b4183..2d7bf4a90052a9f42e9ef2b8edfc5affacf17b75 100644 (file)
                        resets = <&dispcc DISP_CC_MDSS_CORE_BCR>;
 
                        interconnects = <&mmss_noc MASTER_MDP QCOM_ICC_TAG_ALWAYS
-                                        &gem_noc SLAVE_LLCC QCOM_ICC_TAG_ALWAYS>,
-                                       <&mc_virt MASTER_LLCC QCOM_ICC_TAG_ALWAYS
                                         &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
-                       interconnect-names = "mdp0-mem",
-                                            "mdp1-mem";
+                       interconnect-names = "mdp0-mem";
 
                        power-domains = <&dispcc MDSS_GDSC>;